From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Date: Thu, 01 Apr 2021 17:42:38 -0400 Message-ID: References: <87a6qhyish.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 01 23:43:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lS56b-0004oU-Kx for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 23:43:57 +0200 Original-Received: from localhost ([::1]:59856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS56a-0002Mx-LO for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 17:43:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS55V-0001wG-91 for emacs-devel@gnu.org; Thu, 01 Apr 2021 17:42:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS55P-0005pK-64; Thu, 01 Apr 2021 17:42:48 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8EDA644116A; Thu, 1 Apr 2021 17:42:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 29FC94410DA; Thu, 1 Apr 2021 17:42:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617313360; bh=SWOlqymtzvj8AHf6opP+pI1OeifaKobSHtYZNuvrRCo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aLGDhtJqYmlKnJXggBsdHx7mRMNjsJT+woa67Cw66BPyOit4S3nC9XrT0wGRB0scf RQnGUjinLB3MVOhQA99Th2FVHosMz/cWUapEp+cBSF40xx6CuIGW+qbAt7XYjkUmS5 3ktbE4o2CpkTP/Tc2mjAP/TegYmom4Jvl7zp6Q0LVzdySoXr/FgEjC7A2IJmn3pir1 exWDLd06x9zlN5+xmgM8G0+Q1aBPsVvBxR1EVSwhMyJFVnLPRaamgFOLEZAAmmmxhE SVGsYV62uV03iu8QrgHcROrnIFwNKHNJ13nhSd68lVecRggzJi4919D1ZGqZ6HFGkC 6wGXcK1IaqlAw== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8AA27120281; Thu, 1 Apr 2021 17:42:39 -0400 (EDT) In-Reply-To: <87a6qhyish.fsf@catern.com> (Spencer Baugh's message of "Thu, 01 Apr 2021 14:13:50 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267281 Archived-At: > To statically avoid checking Qunbound for vars where it's not necessary, > we need to use separate syntax for accessing BVARs that have defaults > and BVARs that don't have defaults. Only BVARs that have defaults need a > Qunbound check. (We could use the same syntax for both, but it would > require X macros which Eli disliked earlier) BTW, we may also want to try and increase the proportion of those vars which don't have a global default (i.e. look at which variables fall into this camp and that can be changed without too much trouble). Regarding benchmarking, you may also want to try `elisp-benchmarks` in GNU ELPA (I suspect those benchmarks will not be very much influenced by your patch, tho, so please try the "scroll xdisp.c" first). Stefan