From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Native Compilation And External Packages Date: Sat, 29 May 2021 14:52:26 -0400 Message-ID: References: <24754.27537.803673.706445@google.com> <83czt95wco.fsf@gnu.org> <838s3x5tnc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "T.V Raman" , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 29 20:54:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ln464-0009Rd-B1 for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 20:54:08 +0200 Original-Received: from localhost ([::1]:49356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ln461-00021O-DM for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 14:54:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln44Z-0000et-N5 for emacs-devel@gnu.org; Sat, 29 May 2021 14:52:36 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln44U-0003XW-9N; Sat, 29 May 2021 14:52:35 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AB2EC8066C; Sat, 29 May 2021 14:52:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B16C804FD; Sat, 29 May 2021 14:52:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622314347; bh=OEyYnJvIrEnx8SdHUWmCPx2ZY9HZK4J2b4ambEYR6F0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Pb09Fi+vkAKzsvZAp7bI+xJzLZJkJ2k1MbGxy1OE1PYgUIPXhfzA2v7x6VZvlm0q2 2H3WmgkpX3qaO4TqteJn25mIwzZgRssfIZoMeiLoEQ1gwEULfz+wzd1TWR4XUxGuJT sGtId+MoWs6WWNO6zJXNJ/PPbLlAFmoEEV32aa3Mn52O8OXYF+843/6dhDUyCRc1nH vLZzp07UzSbkWNNFrn1BD5WvU9SOziwZ6pZ3Uc4Jf8ci5/35W0urS71k/WT/rak2bk 1UjHzk9D3HN74RG97T13zEba0ZFzT2rgbGpRZTVSGGEWNfDejn9H0psZvttaD9Pt+j LI1Cu6/XmRUyA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 07A2E12105F; Sat, 29 May 2021 14:52:26 -0400 (EDT) In-Reply-To: <838s3x5tnc.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 May 2021 20:36:39 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270091 Archived-At: >> The warnings are inconsistent as in: >> >> Compiling at the command line using -f batch-byte-compile produces no >> warnings; the same code produces warnings when native-emacs is run > > A Stefan says, these are real problems that you should report. they > are not false warnings. IIUC he refers above to the case where his Makefiles only generate the .elc and the .eln are auto-generated lazily later. This is a known issue. IMO it should be fixed by making the lazy native compiler take the .elc file as input instead of restarting from the .el file; those "extra warnings" we get are due to dependencies not being loaded into the Emacs session that does the native compilation and these missing dependencies can cause macro-calls to be compiled as function calls, IOW we may end up miscompiling the files. But of course, part of the blame is in the .el files themselves which should not depend on special Makefile tricks to get the right files preloaded, but it can require a fair bit of work to fix an existing package w.r.t such problems. Also, this used to work so we should strive to keep it working. Stefan