unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master 68c09c6: Better CPS conversion of multi-binding `let`
Date: Tue, 30 Nov 2021 08:19:19 -0500	[thread overview]
Message-ID: <jwvczmhlr5g.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20211130120405.6C5F4209FD@vcs0.savannah.gnu.org> ("Mattias Engdegård"'s message of "Tue, 30 Nov 2021 07:04:05 -0500 (EST)")

> -    ;; Process `let' in a helper function that transforms it into a
> -    ;; let* with temporaries.
> +    (`(,(or 'let 'let*) () . ,body)
> +      (cps--transform-1 `(progn ,@body) next-state))
> +
> +    (`(let (,binding) . ,body)
> +      (cps--transform-1 `(let* (,binding) ,@body) next-state))
> +
> +    ;; Transform multi-variable `let' into `let*':
> +    ;;    (let ((v1 e1) ... (vN eN)) BODY)
> +    ;; -> (let* ((t1 e1) ... (tN eN) (v1 t1) (vN tN)) BODY)

I think this optimization can be generalized to the multi-var case by
noticing that the transformation of (vN eN) into a pair (tN eN) ... (vN tN)
is not necessary because the order of the (v1 t1) ... (vN tN) doesn't matter
so we can move (vN tN) to the beginning, right next to (tN eN) and then
merge them back.


        Stefan




       reply	other threads:[~2021-11-30 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211130120404.23495.29099@vcs0.savannah.gnu.org>
     [not found] ` <20211130120405.6C5F4209FD@vcs0.savannah.gnu.org>
2021-11-30 13:19   ` Stefan Monnier [this message]
2021-11-30 13:30     ` master 68c09c6: Better CPS conversion of multi-binding `let` Mattias Engdegård
2021-11-30 13:42       ` Stefan Monnier
2021-11-30 13:49         ` Mattias Engdegård
2021-11-30 13:54           ` Stefan Monnier
2021-11-30 14:11             ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczmhlr5g.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).