From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/bytecode-speedup 870806d4c4 04/11: Pin bytecode strings to avoid copy at call time Date: Tue, 11 Jan 2022 12:09:33 -0500 Message-ID: References: <164191984181.15147.4731922332585678354@vcs2.savannah.gnu.org> <20220111165048.75C05C0DA31@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7394"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 18:14:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7Kj4-0001ic-31 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 18:14:26 +0100 Original-Received: from localhost ([::1]:42324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7Kj2-00082I-UP for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 12:14:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KeZ-0004PP-Cl for emacs-devel@gnu.org; Tue, 11 Jan 2022 12:09:49 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KeV-0006pW-GF for emacs-devel@gnu.org; Tue, 11 Jan 2022 12:09:46 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 029394422BE; Tue, 11 Jan 2022 12:09:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 48C19440AE0; Tue, 11 Jan 2022 12:09:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641920975; bh=e5l878mxK0clT7r3vCkTCPNMnKM+4W5wPjXKCEyz/rw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=H9nfhH2GjHmKsl1R9yy7Cr0ZS7TAWDqa7rTsgfA/DWrRMYdaPALp3vFLNiv0xWsCY aT4819Nl8gF9MkvWzRmEg6hfHx5Pass6tyce8Sxm+TB2A3+mSJjDcOcVtcNp/ZkLY2 HiKTbAlp9/H/A164B6Fz6eCld1hynKGQuxGokdb1IXGCf8f8JvhsGD0iWYjMou12no 0IoiqEsX5ADuDN9+kD6+t+XXV/FjsOMbJkoEsYAlSXnIzF7Kr62pllRw3/nb1JcUKh Fz4Uau39rpdaw+1KLioU5oh+hCrkeXFO+fSZB/V3Xl98v9UfrusRkndP5wsjXqvXgE 3j9gWHE8H+bvA== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1AF07120384; Tue, 11 Jan 2022 12:09:35 -0500 (EST) In-Reply-To: <20220111165048.75C05C0DA31@vcs2.savannah.gnu.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Tue, 11 Jan 2022 11:50:47 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284617 Archived-At: > branch: scratch/bytecode-speedup > commit 870806d4c453addca794aa0940298425241e13d9 > Author: Mattias Engdeg=E5rd > Commit: Mattias Engdeg=E5rd > > Pin bytecode strings to avoid copy at call time > + /* ... we plonk BYTESTR and VECTOR there to ensure that they survive > + GC (bug#33014), since these variables aren't used directly beyond > + the interpreter prologue and wouldn't be found in the stack frame > + otherwise. */ > + stack_base[0] =3D bytestr; > + stack_base[1] =3D vector; > + Lisp_Object *top =3D stack_base + 1; > + Lisp_Object *stack_lim =3D top + stack_items; > + unsigned char const *bytestr_data =3D SDATA (bytestr); Why not keep a ref to the function object itself? That would also allow providing a new bytecode to extract a `self` reference to the function that's being executed. Oh, I think I can see one reason: there's no such object when we're called from `Fbyte_code`. Maybe `Fbyte_code` should be reimplemented as `(funcall (make-byte-code 0 bytecode csts depth))`? (and change `bytecomp.el` not to use `byte-code` any more) (and mark `byte-code` as obsolete) Stefan