From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Re: Early backtrace. Date: Sun, 30 Jan 2022 11:31:30 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 30 17:32:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nED7s-0002XS-GV for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jan 2022 17:32:28 +0100 Original-Received: from localhost ([::1]:37440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nED7r-0007ow-EQ for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jan 2022 11:32:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nED73-00077l-S1 for emacs-devel@gnu.org; Sun, 30 Jan 2022 11:31:38 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nED71-0003Lo-GY for emacs-devel@gnu.org; Sun, 30 Jan 2022 11:31:37 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 90FF2442AFE; Sun, 30 Jan 2022 11:31:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E0444442B04; Sun, 30 Jan 2022 11:31:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643560291; bh=NBZJJGcuJ8LKm1/Dv4mU7pRHmWygXn1L8vbtmpN1emI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=erccbWbqB9uOfP2Ktwz+gb7uGBBq441e7LO6tpfevxyBtvbDVOXo6iGVdPFD10CzV A2IV5sD1sWAyBV6bTNjQg+fMd7LaNrL9gHR0rnv1xA58TA2EG8G9qzmQEhdqFLfVCX rCRE8a/jbLykHuWuOYuJz+LwVtRpaR5Jb0W9UKienxdGglBrqAVsZNwcSC2MlIMItP 30JY0tyKInCUiGMSfvhYMeQjvM+ryFERRpPgaqVwELDnCCCv5h4Viv6NynpuLp3Qql zVuf6fbw8q3pbZD2aioNZo3vIil2oNhHn3QP6TmuIURgnyS0dBWK+X2ayIwRQvCpcH VzBOjhAW9movQ== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B31C112086B; Sun, 30 Jan 2022 11:31:31 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Sun, 30 Jan 2022 11:07:32 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285616 Archived-At: Alan Mackenzie [2022-01-30 11:07:32] wrote: >> Namespace prefixes don't need to be created before we use them. >> The point is just that `debugger-` is already used by definitions (in >> `debug.el`) so we can reuse that space instead of messing up pristine >> real estate. > OK, I've called it debug-early. Deal! > Are there any objections to me committing this to master? See my comments below. > /* If we're in batch mode, print a backtrace unconditionally to help > - with debugging. Make sure to use `debug' unconditionally to not > - interfere with ERT or other packages that install custom > - debuggers. Don't try to call the debugger while dumping or > - bootstrapping, it wouldn't work anyway. */ > + with debugging. Make sure to use `debug-early' unconditionally > + to not interfere with ERT or other packages that install custom > + debuggers. */ This is not your fault, but I notice that this comment doesn't explain how we distinguish the case where we want to print a backtrace from the case where we want to call ERT's "debugger", both of which can occur in batch mode. > (defalias 'debug-early-backtrace > #'(lambda () > "Print a trace of Lisp function calls currently active. > The output stream used is the value of `standard-output'. > > This is a simplified version of the standard `backtrace' > function, intended for use in debugging the early parts > of the build process." > (princ "\n") > (mapbacktrace > #'(lambda (evald func args _flags) > (let ((args args)) > (if evald > (progn > (princ " ") > (prin1 func) > (princ " (") > (while args > (prin1 (car args)) > (setq args (cdr args)) > (if args > (princ " "))) > (princ ")\n")) > (while args > (princ " ") > (prin1 (car args)) > (princ "\n") > (setq args (cdr args))))))))) > > (defalias 'debug-early > #'(lambda (&rest args) > "Print a trace of Lisp function calls currently active. > The output stream used is the value of `standard-output'. > > There should be two ARGS, the symbol `error' and a cons of > the error symbol and its data. > > This is a simplified version of `debug', intended for use > in debugging the early parts of the build process." > (princ "\nError: ") > (prin1 (car (car (cdr args)))) ; The error symbol. > (princ " ") > (prin1 (cdr (car (cdr args)))) ; The error data. > (debug-early-backtrace))) I'm curious: why did you split this into two functions? > (setq debugger #'debug-early) Could we make `debug-early` the default/initial value of `debugger` in the C code, so that reloading `debug-early.el` can be done safely? Stefan