From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f515d658e5 1/2: Don't quote numbers in byte-run--set-* Date: Fri, 17 Jun 2022 14:01:44 -0400 Message-ID: References: <165548588979.10920.4402229762078749924@vcs2.savannah.gnu.org> <20220617171130.8EDECC01685@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 17 20:05:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2GLG-000297-Fw for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 20:05:10 +0200 Original-Received: from localhost ([::1]:54792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2GLE-0008PI-Vn for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 14:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2GI6-0006fy-3V for emacs-devel@gnu.org; Fri, 17 Jun 2022 14:01:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2GI3-0005t1-Fe for emacs-devel@gnu.org; Fri, 17 Jun 2022 14:01:53 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 85143100674; Fri, 17 Jun 2022 14:01:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DE6CC1003FF; Fri, 17 Jun 2022 14:01:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655488905; bh=6Cm00rkSl+iejAt4RPEAPyrp7m58EDNIVdI7iXAZBkE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QKu6pfucpL0ay5lwy8Yghh34bny8dnQKdzn0icBXf0O9v74CC0sgEE9KtBzmWr2W6 JGwzggyWdJw/wrRB2czC5DVmRf64VaBHEfthuXH4IO3w6vyjIjx5tfL/k/P6/GMi7R p+x4DLyyp6gC5oe881rw6OyUAJ13aZRIrOwDg0AJezMQPX9ZW2OIyU2gn8WANDzFFF XKkTFIky1Vhot1hjaTMqBHiAp1DxFBjcVJ8BCM+SMgcqFltjemCPTyE8XljcmQGC6n 9EeWbmBCWBaWzF9aThZAZV9b2P32hyG7x2jf1HssiTBylSq+ovnGl2J27jDA8PRX+b +/0peG4FoJ/+A== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8CE3F120377; Fri, 17 Jun 2022 14:01:45 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 17 Jun 2022 13:58:17 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291310 Archived-At: > Should we push this one a step further, as below? Duh! Wrong patch, sorry, Stefan diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index dd90bcf4d82..76f49e36f62 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -210,9 +210,7 @@ 'byte-run--set-compiler-macro (defalias 'byte-run--set-doc-string #'(lambda (f _args pos) (list 'function-put (list 'quote f) - ''doc-string-elt (if (numberp pos) - pos - (list 'quote pos))))) + ''doc-string-elt pos))) (defalias 'byte-run--set-indent #'(lambda (f _args val) diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 200af057cd7..b1579a61fe5 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -545,7 +545,7 @@ cl-defmethod \(and can be extended) by the various methods of `cl-generic-generalizers'. \(fn NAME [EXTRA] [QUALIFIER] ARGS &rest [DOCSTRING] BODY)" - (declare (doc-string cl--defmethod-doc-pos) (indent defun) + (declare (doc-string #'cl--defmethod-doc-pos) (indent defun) (debug (&define ; this means we are defining something [&name [sexp ;Allow (setf ...) additionally to symbols.