unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master f515d658e5 1/2: Don't quote numbers in byte-run--set-*
Date: Fri, 17 Jun 2022 14:01:44 -0400	[thread overview]
Message-ID: <jwvczf75fvn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwviloz5g7g.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 17 Jun 2022 13:58:17 -0400")

> Should we push this one a step further, as below?

Duh!  Wrong patch, sorry,


        Stefan


diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index dd90bcf4d82..76f49e36f62 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -210,9 +210,7 @@ 'byte-run--set-compiler-macro
 (defalias 'byte-run--set-doc-string
   #'(lambda (f _args pos)
       (list 'function-put (list 'quote f)
-            ''doc-string-elt (if (numberp pos)
-                                 pos
-                               (list 'quote pos)))))
+            ''doc-string-elt pos)))
 
 (defalias 'byte-run--set-indent
   #'(lambda (f _args val)
diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 200af057cd7..b1579a61fe5 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -545,7 +545,7 @@ cl-defmethod
 \(and can be extended) by the various methods of `cl-generic-generalizers'.
 
 \(fn NAME [EXTRA] [QUALIFIER] ARGS &rest [DOCSTRING] BODY)"
-  (declare (doc-string cl--defmethod-doc-pos) (indent defun)
+  (declare (doc-string #'cl--defmethod-doc-pos) (indent defun)
            (debug
             (&define                    ; this means we are defining something
              [&name [sexp   ;Allow (setf ...) additionally to symbols.




  reply	other threads:[~2022-06-17 18:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165548588979.10920.4402229762078749924@vcs2.savannah.gnu.org>
     [not found] ` <20220617171130.8EDECC01685@vcs2.savannah.gnu.org>
2022-06-17 17:58   ` master f515d658e5 1/2: Don't quote numbers in byte-run--set-* Stefan Monnier
2022-06-17 18:01     ` Stefan Monnier [this message]
2022-06-17 18:08       ` Lars Ingebrigtsen
2022-06-17 18:20         ` Stefan Monnier
2022-06-18 11:32           ` Lars Ingebrigtsen
2022-06-18 13:34             ` Stefan Monnier
2022-06-19 11:10               ` Lars Ingebrigtsen
2022-06-19 12:57                 ` Basil L. Contovounesios
2022-06-19 13:15                   ` Lars Ingebrigtsen
2022-06-19 16:19                     ` Michael Heerdegen
2022-06-19 22:30                       ` Lars Ingebrigtsen
2022-06-19 22:24                 ` Stefan Monnier
2022-06-19 22:29                   ` Lars Ingebrigtsen
2022-06-19 23:12                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczf75fvn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).