From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2de25accaf 4/4: Warn about `condition-case' with quoted condition names Date: Thu, 29 Dec 2022 09:45:06 -0500 Message-ID: References: <167231424264.29966.177874348975736593@vcs2.savannah.gnu.org> <20221229114403.7EA13C05F48@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 29 15:45:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAuAR-0004m9-KG for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Dec 2022 15:45:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAu9r-0001tk-MP; Thu, 29 Dec 2022 09:45:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAu9k-0001sx-F9 for emacs-devel@gnu.org; Thu, 29 Dec 2022 09:45:16 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAu9g-0001nq-GZ for emacs-devel@gnu.org; Thu, 29 Dec 2022 09:45:13 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6913D4410CC; Thu, 29 Dec 2022 09:45:10 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 22B4044108E; Thu, 29 Dec 2022 09:45:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672325109; bh=DM1v22hIMsUuFVFWpY9/Hbbi8iIhXN2DTLs8qqNPQxM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HD6JE6551+kAR3hJRwRZ1YhZAThGUPWvhL2JN5mChsVSdPql/uwrFMDO8a6oNVCEO PC2Dng1HC2k+TBPE7/DFL5Rko3T1yvyuHlyQDUfiXAddqB4Z58gTOQT11OP4v/Umqy uXkT1Utngs7ca0ObXs7eHyrkuUCDHosjzBWXrdScZDIwifzJ08kNkxv+cUCyj7fX1R miT0A90RK0XuPB2qBlzWnrAQxhBcFaJ8QdltBGTmkjLAVSHC1zVxSaE0hpg5kCn/fE 7SWQfQ4exrWqwqkSWQ2FLrpAtsm80+x8AAR5UV5bWiu1r45w76WmZKF5gT1mJGWwqN +RI8mfgDWl0xg== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CEF0E12063B; Thu, 29 Dec 2022 09:45:08 -0500 (EST) In-Reply-To: <20221229114403.7EA13C05F48@vcs2.savannah.gnu.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 29 Dec 2022 06:44:03 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302031 Archived-At: > + (when (and (eq (car-safe condition) 'quote) > + (cdr condition) (null (cddr condition))) > + (byte-compile-warn-x > + condition "`condition-case' condition should not be quoted: %S" > + condition)) Shouldn't we instead warn about any unknown error signals? Stefan