unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: nicolas@n16f.net,  emacs-devel@gnu.org
Subject: Re: [PATCH] em-cmpl: fix completion of command paths
Date: Fri, 27 Jan 2023 19:12:11 -0500	[thread overview]
Message-ID: <jwvcz6zecw6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83ilgufsdb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Jan 2023 19:15:12 +0200")

>> Eli, what do you think?
> Yes, this is okay for emacs-29.

Thanks, I'll push it soon.

>> > +    ;; Do not use `completion-table-dynamic' when completing a command path
>> > +    ;; (absolute or relative): doing so assumes that the subpath in the input
>> > +    ;; string is always a command, and appends a space character, which is
>> > +    ;; incorrect (i.e. "/usr/bi" should yield "/usr/bin/" after completion,
>> > +    ;; not "/usr/bin/ ").
>
> Please use "file name", not "path", when referring to file or
> directory names.  If you need to make it clear you are talking about
> absolute file name, use "absolute file name" or "file name with
> leading directories".  GNU coding standards frown on using "path" for
> anything but PATH-style lists of directories.  (Yes, I know that most
> of this text came from a comment in the original code.)

Thanks for catching this.


        Stefan




  parent reply	other threads:[~2023-01-28  0:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07 12:19 [PATCH] em-cmpl: fix completion of command paths Nicolas Martyanoff
2023-01-07 12:23 ` Nicolas Martyanoff
2023-01-13 10:59   ` Nicolas Martyanoff
2023-01-25 17:03 ` Stefan Monnier
2023-01-25 17:15   ` Eli Zaretskii
2023-01-25 20:32     ` [PATCH] Update compat Nicolas Martyanoff
     [not found]     ` <87bkmmwcwx.fsf@valhala.localdomain>
2023-01-26  6:02       ` [PATCH] em-cmpl: fix completion of command paths Eli Zaretskii
2023-01-26  9:06         ` Eli Zaretskii
2023-01-26 12:21           ` Nicolas Martyanoff
2023-01-26 12:58             ` Eli Zaretskii
2023-01-28  0:11           ` Stefan Monnier
2023-01-28  8:27             ` Eli Zaretskii
2023-01-28  0:12     ` Stefan Monnier [this message]
2023-01-25 21:50   ` Jim Porter
2023-02-08  6:06 ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvcz6zecw6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=nicolas@n16f.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).