From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Problems with debug-on-entry in the Lisp debugger. Date: Mon, 07 Mar 2005 11:32:58 -0500 Message-ID: References: <87sm37n2bv.fsf@xs4all.nl> <87hdjnegak.fsf-monnier+emacs@gnu.org> <876503wkh4.fsf@xs4all.nl> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1110212952 8420 80.91.229.2 (7 Mar 2005 16:29:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2005 16:29:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 07 17:29:11 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D8L5V-0005pI-V0 for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 17:28:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8LPJ-0003TN-Cz for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 11:48:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D8LP4-0003Sn-9t for emacs-devel@gnu.org; Mon, 07 Mar 2005 11:48:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D8LP2-0003SE-FR for emacs-devel@gnu.org; Mon, 07 Mar 2005 11:48:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8LP2-0003SB-D6 for emacs-devel@gnu.org; Mon, 07 Mar 2005 11:48:20 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D8LAH-0007B7-Mr for emacs-devel@gnu.org; Mon, 07 Mar 2005 11:33:05 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 4C854340012; Mon, 7 Mar 2005 11:33:03 -0500 (EST) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id B6A024AC008; Mon, 7 Mar 2005 11:32:58 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 8FE5A4C20D; Mon, 7 Mar 2005 11:32:58 -0500 (EST) Original-To: Lute Kamstra In-Reply-To: <876503wkh4.fsf@xs4all.nl> (Lute Kamstra's message of "Mon, 07 Mar 2005 16:20:55 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.815, requis 5, autolearn=not spam, AWL 0.09, BAYES_00 -4.90) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34284 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34284 > I see you implemented this. This makes debug-on-entry for macros a > lot better, of course. Thanks. But the problem I mentioned remains: > the debug-entry-code is visible. [...] > Debugger entered--entering a function: > * (lambda (var) (if (or inhibit-debug-on-entry debugger-jumping-flag) nil (debug ...)) (list (quote setq) var (list ... var)))(x) > (inc x) [...] Other than the aesthetic aspect (which we can fix by just removing the offending line in an ad-hoc way), does it have any real impact? > I think the effect on performance will be very minimal. But I see no compelling reason to pay this price. After all, we've live for many years with this elisp implementation without nearly any complaint. If the aesthetic aspect is just more serious now that we replace (debug 'debug) with (if (or inhibit-debug-on-entry debugger-jumping-flag) nil (debug 'debug)), we can define a function named e.g. `debug-entering' that will do the checking of inhibit-debug-on-entry and debugger-jumping-flag. Stefan