From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [cezar@mixandgo.ro: skeleton bug] Date: Mon, 03 Sep 2007 17:22:57 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1188854598 29559 80.91.229.12 (3 Sep 2007 21:23:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Sep 2007 21:23:18 +0000 (UTC) Cc: emacs-devel@gnu.org, cezar@mixandgo.ro, Kenichi Handa To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 23:23:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ISJO3-0002sl-1s for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 23:23:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISJO1-0005ZP-QO for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 17:23:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ISJNw-0005Xr-Cp for emacs-devel@gnu.org; Mon, 03 Sep 2007 17:23:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ISJNv-0005X1-HL for emacs-devel@gnu.org; Mon, 03 Sep 2007 17:23:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISJNv-0005Ws-80 for emacs-devel@gnu.org; Mon, 03 Sep 2007 17:23:03 -0400 Original-Received: from tomts43-srv.bellnexxia.net ([209.226.175.110]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ISJNq-0006yA-3d; Mon, 03 Sep 2007 17:22:58 -0400 Original-Received: from pastel.home ([70.55.144.31]) by tomts43-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070903212257.IWVF26794.tomts43-srv.bellnexxia.net@pastel.home>; Mon, 3 Sep 2007 17:22:57 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 44E298582; Mon, 3 Sep 2007 17:22:56 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Mon\, 03 Sep 2007 14\:25\:52 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77691 Archived-At: > I found that this is because of the following incompatible > change in emacs-unicode-2. > Emacs-22: (char-or-string-p -1) => t > Emacs-23: (char-or-string-p -1) => nil > According to the function name, I think it should return nil > on -1. > Which do you think is better? > (1) Revert the change of char-or-string-p. > (2) Keep char-or-string-p as is in emacs-unicode-2, > make a new function integer-or-string-p, and check all > occurrences of char-or-string-p in *.el files. > I think we should keep the changed behavior of char-or-string-p, > which fits with its name, and check all 8 callers. Agreed, Stefan