unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* 23.0.60; bad global variable name
@ 2008-06-01 17:31 Drew Adams
  2008-06-05  5:49 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2008-06-01 17:31 UTC (permalink / raw)
  To: emacs-pretest-bug

The naming of these two, related global variables is inconsistent:
 
minibuffer-local-filename-completion-map
minibuffer-local-must-match-filename-map
 
They should both use the same naming convention. Since this error was
introduced in Emacs 22, the remedy is to rename one of them for Emacs
23 (and future) and create a deprecated alias for its old name.
 
I suggest that we use this name:
minibuffer-local-filename-must-match-map.
 
Alternatively, we could use this name:
minibuffer-local-completion-filename-map.  But I think that such a
naming convention would be less clear.
 
What's important is to use the same naming convention for both,
regardless of what that convention is.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-05-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 23.0.60; bad global variable name
  2008-06-01 17:31 23.0.60; bad global variable name Drew Adams
@ 2008-06-05  5:49 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2008-06-05  5:49 UTC (permalink / raw)
  To: Drew Adams; +Cc: emacs-pretest-bug

> I suggest that we use this name:
> minibuffer-local-filename-must-match-map.
 
Done,


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-05  5:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-01 17:31 23.0.60; bad global variable name Drew Adams
2008-06-05  5:49 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).