unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Sporadic differences after a bootstrap
@ 2009-09-11  9:46 Eli Zaretskii
  2009-09-11 10:25 ` Juanma Barranquero
  2009-09-11 16:53 ` Andreas Schwab
  0 siblings, 2 replies; 7+ messages in thread
From: Eli Zaretskii @ 2009-09-11  9:46 UTC (permalink / raw)
  To: emacs-devel

After bootstrapping with today's CVS, two files become different from
what's in CVS:

  Index: lisp/emacs-lisp/cl-loaddefs.el
  ===================================================================
  RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/cl-loaddefs.el,v
  retrieving revision 1.25
  diff -u -r1.25 cl-loaddefs.el
  --- lisp/emacs-lisp/cl-loaddefs.el	7 Sep 2009 15:25:38 -0000	1.25
  +++ lisp/emacs-lisp/cl-loaddefs.el	11 Sep 2009 09:47:23 -0000
  @@ -282,7 +282,7 @@
   ;;;;;;  do-all-symbols do-symbols dotimes dolist do* do loop return-from
   ;;;;;;  return block etypecase typecase ecase case load-time-value
   ;;;;;;  eval-when destructuring-bind function* defmacro* defun* gentemp
  -;;;;;;  gensym) "cl-macs" "cl-macs.el" "51f6e3d56342c5e4434dbb7fda3b2e1c")
  +;;;;;;  gensym) "cl-macs" "cl-macs.el" "2aecc3d85778ca624e541d08032aa12a")
   ;;; Generated autoloads from cl-macs.el

   (autoload 'gensym "cl-macs" "\
  Index: lisp/mail/rmail.el
  ===================================================================
  RCS file: /cvsroot/emacs/emacs/lisp/mail/rmail.el,v
  retrieving revision 1.545
  diff -u -r1.545 rmail.el
  --- lisp/mail/rmail.el	10 Sep 2009 06:19:34 -0000	1.545
  +++ lisp/mail/rmail.el	11 Sep 2009 09:47:27 -0000
  @@ -4186,7 +4186,7 @@
   \f
   ;;;### (autoloads (rmail-next-labeled-message rmail-previous-labeled-message
   ;;;;;;  rmail-read-label rmail-kill-label rmail-add-label) "rmailkwd"
  -;;;;;;  "rmailkwd.el" "2a8211ddb881a6eeb44634909fecb6ee")
  +;;;;;;  "rmailkwd.el" "2e986921026eea971b49e91f53967f77")
   ;;; Generated autoloads from rmailkwd.el

   (autoload 'rmail-add-label "rmailkwd" "\

Why does this happen?  Is this a real problem?





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11  9:46 Sporadic differences after a bootstrap Eli Zaretskii
@ 2009-09-11 10:25 ` Juanma Barranquero
  2009-09-11 17:31   ` Glenn Morris
  2009-09-11 16:53 ` Andreas Schwab
  1 sibling, 1 reply; 7+ messages in thread
From: Juanma Barranquero @ 2009-09-11 10:25 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

On Fri, Sep 11, 2009 at 11:46, Eli Zaretskii <eliz@gnu.org> wrote:

> After bootstrapping with today's CVS, two files become different from
> what's in CVS:

>  -;;;;;;  gensym) "cl-macs" "cl-macs.el" "51f6e3d56342c5e4434dbb7fda3b2e1c")
>  +;;;;;;  gensym) "cl-macs" "cl-macs.el" "2aecc3d85778ca624e541d08032aa12a")

>  -;;;;;;  "rmailkwd.el" "2a8211ddb881a6eeb44634909fecb6ee")
>  +;;;;;;  "rmailkwd.el" "2e986921026eea971b49e91f53967f77")

> Why does this happen? Is this a real problem?

Glenn is using `generated-autoload-file' in some files so their
autoloads are in their "parent" file, instead of loaddefs.el (for
example, ibuf-ext.el's autoloads now go into ibuffer.el, dired-*.el's
into dired.el, etc.). The downside is that these parent files must be
updated into the CVS whenever the checksum varies.

    Juanma




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11  9:46 Sporadic differences after a bootstrap Eli Zaretskii
  2009-09-11 10:25 ` Juanma Barranquero
@ 2009-09-11 16:53 ` Andreas Schwab
  1 sibling, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2009-09-11 16:53 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> Why does this happen?  Is this a real problem?

Just commit them when it happens.  The last one modifying the referenced
files didn't bother to update the autoloads.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11 10:25 ` Juanma Barranquero
@ 2009-09-11 17:31   ` Glenn Morris
  2009-09-11 17:39     ` Juanma Barranquero
  2009-09-11 18:42     ` Stefan Monnier
  0 siblings, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2009-09-11 17:31 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: Eli Zaretskii, emacs-devel

Juanma Barranquero wrote:

> Glenn is using `generated-autoload-file' in some files so their
> autoloads are in their "parent" file, instead of loaddefs.el (for
> example, ibuf-ext.el's autoloads now go into ibuffer.el, dired-*.el's
> into dired.el, etc.). The downside is that these parent files must be
> updated into the CVS whenever the checksum varies.

If it bothers people, the other way to do this is to have a completely
generated file (eg rmail-loaddefs.el) that is not stored in the
repository at all. Either way is fine by me.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11 17:31   ` Glenn Morris
@ 2009-09-11 17:39     ` Juanma Barranquero
  2009-09-11 17:56       ` Glenn Morris
  2009-09-11 18:42     ` Stefan Monnier
  1 sibling, 1 reply; 7+ messages in thread
From: Juanma Barranquero @ 2009-09-11 17:39 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Eli Zaretskii, emacs-devel

On Fri, Sep 11, 2009 at 19:31, Glenn Morris <rgm@gnu.org> wrote:

> If it bothers people, the other way to do this is to have a completely
> generated file (eg rmail-loaddefs.el) that is not stored in the
> repository at all. Either way is fine by me.

That seems a bit cleaner to me, but it is not really that important.

    Juanma




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11 17:39     ` Juanma Barranquero
@ 2009-09-11 17:56       ` Glenn Morris
  0 siblings, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2009-09-11 17:56 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: Eli Zaretskii, emacs-devel


I should also have said that ps-print has been using this mechanism
for some time, and it doesn't seem to have caused too much trouble. So
now that this has settled down, if people give it a chance, I don't
think it will be noticeable.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Sporadic differences after a bootstrap
  2009-09-11 17:31   ` Glenn Morris
  2009-09-11 17:39     ` Juanma Barranquero
@ 2009-09-11 18:42     ` Stefan Monnier
  1 sibling, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2009-09-11 18:42 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Juanma Barranquero, Eli Zaretskii, emacs-devel

>> Glenn is using `generated-autoload-file' in some files so their
>> autoloads are in their "parent" file, instead of loaddefs.el (for
>> example, ibuf-ext.el's autoloads now go into ibuffer.el, dired-*.el's
>> into dired.el, etc.). The downside is that these parent files must be
>> updated into the CVS whenever the checksum varies.

> If it bothers people, the other way to do this is to have a completely
> generated file (eg rmail-loaddefs.el) that is not stored in the
> repository at all. Either way is fine by me.

Both ways are currently used in Emacs (many of them setup by yours
truly), and the deciding factor was generally the size of the file.
If the rmail-loaddefs.el would be tiny, it's not worth the trouble.


        Stefan




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-09-11 18:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-11  9:46 Sporadic differences after a bootstrap Eli Zaretskii
2009-09-11 10:25 ` Juanma Barranquero
2009-09-11 17:31   ` Glenn Morris
2009-09-11 17:39     ` Juanma Barranquero
2009-09-11 17:56       ` Glenn Morris
2009-09-11 18:42     ` Stefan Monnier
2009-09-11 16:53 ` Andreas Schwab

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).