unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Compiler warnings in dired.c
@ 2009-10-24 21:26 Eli Zaretskii
  2009-10-24 22:38 ` Andreas Schwab
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2009-10-24 21:26 UTC (permalink / raw)
  To: emacs-devel

This change:

 2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
 
 	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
 	can properly handle unsigned types.
 	(make_uid, make_gid): Removed.

causes these warnings on a 64-bit host:

  dired.c: In function 'Ffile_attributes':
  dired.c:1039: warning: comparison is always false due to limited range of data type
  dired.c:1039: warning: comparison is always false due to limited range of data type
  dired.c:1043: warning: comparison is always false due to limited range of data type
  dired.c:1043: warning: comparison is always false due to limited range of data type




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Compiler warnings in dired.c
  2009-10-24 21:26 Compiler warnings in dired.c Eli Zaretskii
@ 2009-10-24 22:38 ` Andreas Schwab
  2009-10-25  0:57   ` Stefan Monnier
  2009-10-25  4:11   ` Eli Zaretskii
  0 siblings, 2 replies; 6+ messages in thread
From: Andreas Schwab @ 2009-10-24 22:38 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> This change:
>
>  2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
>  
>  	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
>  	can properly handle unsigned types.
>  	(make_uid, make_gid): Removed.
>
> causes these warnings on a 64-bit host:

This is unavoidable.  Just disable the them, they are useless.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Compiler warnings in dired.c
  2009-10-24 22:38 ` Andreas Schwab
@ 2009-10-25  0:57   ` Stefan Monnier
  2009-10-25  4:11   ` Eli Zaretskii
  1 sibling, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2009-10-25  0:57 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: Eli Zaretskii, emacs-devel

> This is unavoidable.  Just disable the them, they are useless.

100% agreed.


        Stefan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Compiler warnings in dired.c
  2009-10-24 22:38 ` Andreas Schwab
  2009-10-25  0:57   ` Stefan Monnier
@ 2009-10-25  4:11   ` Eli Zaretskii
  2009-10-25  8:34     ` Andreas Schwab
  1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2009-10-25  4:11 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: emacs-devel

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 25 Oct 2009 00:38:24 +0200
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This change:
> >
> >  2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
> >  
> >  	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
> >  	can properly handle unsigned types.
> >  	(make_uid, make_gid): Removed.
> >
> > causes these warnings on a 64-bit host:
> 
> This is unavoidable.  Just disable the them, they are useless.

I didn't enable any warnings.  This is using the stock
src/Makefile.in.  For the record, the GCC version is this:

    gcc (GCC) 4.0.3 (Ubuntu 4.0.3-1ubuntu5)




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Compiler warnings in dired.c
  2009-10-25  4:11   ` Eli Zaretskii
@ 2009-10-25  8:34     ` Andreas Schwab
  2009-10-25 18:33       ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2009-10-25  8:34 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> I didn't enable any warnings.

You can disable them.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Compiler warnings in dired.c
  2009-10-25  8:34     ` Andreas Schwab
@ 2009-10-25 18:33       ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2009-10-25 18:33 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: emacs-devel

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 25 Oct 2009 09:34:48 +0100
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I didn't enable any warnings.
> 
> You can disable them.

Please do.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-10-25 18:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-24 21:26 Compiler warnings in dired.c Eli Zaretskii
2009-10-24 22:38 ` Andreas Schwab
2009-10-25  0:57   ` Stefan Monnier
2009-10-25  4:11   ` Eli Zaretskii
2009-10-25  8:34     ` Andreas Schwab
2009-10-25 18:33       ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).