unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: Thierry Volpiatto <thierry.volpiatto@gmail.com>,
	Ivan Kanis <ivan.kanis@googlemail.com>,
	emacs-devel@gnu.org
Subject: Re: problems with flet on last emacs
Date: Sat, 10 Nov 2012 18:38:53 -0500	[thread overview]
Message-ID: <jwvbof5owzu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALDnm52p=wKhPAw7fod7dCXe8QdMd3syQao50eni6LCG2HgKLA@mail.gmail.com> ("João Távora"'s message of "Sat, 10 Nov 2012 23:07:05 +0000")

> (let ((saved (symbol-function 'foo)))
>   (unwind-protect
>       (progn
>         (fset 'foo #'(lambda ()
>                        (message "bar!")))
>         (meta-foo))
>     (fset 'foo saved)))

Same problem as with flet: the redefinition is hard to find, dynamically
scoped, etc...

Better use

   (defvar foo-bar nil)
   (defadvice foo (around blabla activate)
     (if foo-bar (message "bar!") ad-do-it))

and then

   ...
   (let ((foo-bar t))
     ...)

So C-h f foo RET will tell you about the redefinition and you can
recover the non-redefined behavior with a simple (setq foo-bar nil).


        Stefan



  reply	other threads:[~2012-11-10 23:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 12:36 problems with flet on last emacs Thierry Volpiatto
2012-06-27 12:49 ` Pascal J. Bourguignon
2012-06-27 15:29   ` Stefan Monnier
2012-06-27 16:38     ` Thierry Volpiatto
2012-06-28  6:53     ` Ivan Kanis
2012-06-28  7:31       ` Thierry Volpiatto
2012-06-29  5:42         ` Ivan Kanis
2012-06-29  6:17           ` Thierry Volpiatto
2012-07-12  8:22             ` Ivan Kanis
2012-07-12 14:40               ` Stefan Monnier
2012-07-12 16:44                 ` Ivan Kanis
2012-11-09 17:41                   ` João Távora
2012-11-09 19:23                     ` Stefan Monnier
2012-11-10 14:12                       ` João Távora
2012-11-10 22:46                         ` Stefan Monnier
2012-11-10 23:07                           ` João Távora
2012-11-10 23:38                             ` Stefan Monnier [this message]
2012-11-12  8:02                               ` Andreas Röhler
2012-06-27 13:24 ` Tassilo Horn
2012-06-27 13:43   ` Thierry Volpiatto
2012-06-27 14:27   ` Thierry Volpiatto
2012-06-27 14:42   ` Pascal J. Bourguignon
2012-06-27 15:55     ` Tassilo Horn
2012-06-27 16:29       ` Pascal J. Bourguignon
2012-06-27 19:42         ` Tassilo Horn
2012-06-27 19:46           ` Pascal J. Bourguignon
2012-06-27 15:01   ` Andreas Schwab
2012-06-27 16:03     ` Tassilo Horn
2012-06-27 16:22 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbof5owzu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ivan.kanis@googlemail.com \
    --cc=joaotavora@gmail.com \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).