From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r113822: Add a test for decompressing gzipped data
Date: Tue, 13 Aug 2013 10:41:54 -0400 [thread overview]
Message-ID: <jwvbo51k696.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83iozapan0.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Aug 2013 05:50:11 +0300")
> The 2 fboundp tests return non-nil when Emacs was built with zlib
> support. zlib-available-p can return nil on MS-Windows, when the zlib
> shared library is not available, even though Emacs was built with zlib
> support. On platforms other than Windows, the fboundp tests and
> testing the return value of zlib-available-p are equivalent.
Can't we get rid of zlib-available-p entirely.
Just replace
(if (and (fboundp 'zlib-available-p) (zlib-available-p))
(zlib-decompress-region ...)
blabla)
with
(condition-case nil
(zlib-decompress-region ...)
((void-function zlib-not-available)
blabla))
Hmm... but the above is not recognized by the byte-compiler either, so
you'll still see the spurious warning :-(
The best would really be
(if (fboundp 'zlib-decompress-region)
(zlib-decompress-region ...)
blabla)
but I guess we can't have that because we also want to lazy-load the
zlib shared library, right?
Stefan
next prev parent reply other threads:[~2013-08-13 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V8wyP-0003i5-8r@vcs.savannah.gnu.org>
2013-08-13 1:56 ` [Emacs-diffs] trunk r113822: Add a test for decompressing gzipped data Stefan Monnier
2013-08-13 2:50 ` Eli Zaretskii
2013-08-13 3:45 ` Juanma Barranquero
2013-08-13 4:24 ` Stephen J. Turnbull
2013-08-13 9:54 ` Lars Magne Ingebrigtsen
2013-08-13 16:02 ` Eli Zaretskii
2013-08-13 16:10 ` Lars Magne Ingebrigtsen
2013-08-13 14:41 ` Stefan Monnier [this message]
2013-08-13 14:47 ` Paul Eggert
2013-08-13 16:27 ` Eli Zaretskii
2013-08-13 16:25 ` Eli Zaretskii
2013-08-13 16:30 ` Lars Magne Ingebrigtsen
2013-08-13 16:49 ` Stefan Monnier
2013-08-13 18:04 ` Eli Zaretskii
2013-08-13 18:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbo51k696.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).