From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Wed, 19 Nov 2014 23:18:12 -0500 Message-ID: References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> <85ppclgcec.fsf@stephe-leake.org> <85siheg211.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416457120 29205 80.91.229.3 (20 Nov 2014 04:18:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 04:18:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 20 05:18:33 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrJCS-0005Fs-ND for ged-emacs-devel@m.gmane.org; Thu, 20 Nov 2014 05:18:32 +0100 Original-Received: from localhost ([::1]:33482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJCS-00034U-8K for ged-emacs-devel@m.gmane.org; Wed, 19 Nov 2014 23:18:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJCH-000327-T6 for emacs-devel@gnu.org; Wed, 19 Nov 2014 23:18:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrJCA-0007EC-Ec for emacs-devel@gnu.org; Wed, 19 Nov 2014 23:18:21 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:43528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJCA-0007E7-Ao for emacs-devel@gnu.org; Wed, 19 Nov 2014 23:18:14 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sAK4IDM8028927; Wed, 19 Nov 2014 23:18:13 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D449E3D01; Wed, 19 Nov 2014 23:18:12 -0500 (EST) In-Reply-To: <85siheg211.fsf@stephe-leake.org> (Stephen Leake's message of "Wed, 19 Nov 2014 18:15:54 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5130=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5130> : inlines <1546> : streams <1345465> : uri <1835377> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177850 Archived-At: > This _should_ be caught by a byte-compiler warning > ("find-definition-function not known"). I wouldn't bet on it. > So I'm ok with requiring major modes to either have "(require > find-definition)" or use setq-local. The normal course of event for major mode is to set variables via `setq-local' (or its equivalent for use on older Emacsen). So there's no good reason to use make-variable-buffer-local for that; it'd just be asking for trouble. Stefan