From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695). Date: Tue, 14 Jun 2016 22:12:01 -0400 Message-ID: References: <20160614214332.2901.16184@vcs.savannah.gnu.org> <20160614214332.C030F220116@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465956753 29763 80.91.229.3 (15 Jun 2016 02:12:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 02:12:33 +0000 (UTC) Cc: Stephen Berman To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 15 04:12:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bD0JX-0000XI-Mw for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 04:12:19 +0200 Original-Received: from localhost ([::1]:39168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD0JW-0008M8-K0 for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 22:12:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD0JQ-0008M0-S4 for emacs-devel@gnu.org; Tue, 14 Jun 2016 22:12:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD0JM-0007gL-K5 for emacs-devel@gnu.org; Tue, 14 Jun 2016 22:12:11 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:48017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD0JM-0007gG-FZ for emacs-devel@gnu.org; Tue, 14 Jun 2016 22:12:08 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u5F2C1qK031896; Tue, 14 Jun 2016 22:12:01 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 63045AE580; Tue, 14 Jun 2016 22:12:01 -0400 (EDT) In-Reply-To: <20160614214332.C030F220116@vcs.savannah.gnu.org> (Stephen Berman's message of "Tue, 14 Jun 2016 21:43:32 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5706=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5706> : inlines <4932> : streams <1652123> : uri <2231023> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204366 Archived-At: > - (let ((map minibuffer-local-completion-map)) > - (define-key map " " nil) > + (let ((minibuffer-local-completion-map > + (copy-keymap minibuffer-local-completion-map))) > + (define-key minibuffer-local-completion-map " " 'self-insert-command) Why bind it to `self-insert-command` rather than to nil? Stefan PS: You can avoid copying with something like (let ((minibuffer-local-completion-map (let ((map (make-sparse-keymap))) (set-parent-keymap map minibuffer-local-completion-map) (define-key minibuffer-local-completion-map " " 'self-insert-command))))