From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Tue, 12 Jul 2016 18:58:12 -0400 Message-ID: References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468364350 5345 80.91.229.3 (12 Jul 2016 22:59:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 22:59:10 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 00:58:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bN6dj-0005QB-Us for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 00:58:56 +0200 Original-Received: from localhost ([::1]:43976 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6dj-0002fL-3d for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 18:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6dD-0002Vz-Rr for emacs-devel@gnu.org; Tue, 12 Jul 2016 18:58:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN6d8-0002HD-RZ for emacs-devel@gnu.org; Tue, 12 Jul 2016 18:58:22 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:34984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN6d8-0002H7-Kk for emacs-devel@gnu.org; Tue, 12 Jul 2016 18:58:18 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bN6d7-00055e-4Y for emacs-devel@gnu.org; Wed, 13 Jul 2016 00:58:17 +0200 Original-Received: from 69-165-156-121.dsl.teksavvy.com ([69.165.156.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 00:58:17 +0200 Original-Received: from monnier by 69-165-156-121.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 00:58:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-156-121.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:lRRhgCKGjtitAzP/IQDMdadyavY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205601 Archived-At: EZ> Unlike Stefan, I think we should add :group to every defcustom. Having EZ> them mysteriously missing from some of them is a time bomb: The way I see it, defcustoms should pretty much never have :group, and the group to which they belong is simply determined by the file in which they occur. E.g. the `mouse' group should be defined in mouse.el rather than in cus-edit.el, which would have solved this problem. EZ> remove or add EZ> enough defcustoms in the same file, and you have a bug. I don't see how removing/adding defcustoms in the same file would introduce problems. Stefan PS: Incidentally, we have two definitions of the `mouse' group in cus-edit.el: % grep -A2 '(defgroup mouse ' **/*.el lisp/cus-edit.el:(defgroup mouse nil lisp/cus-edit.el- "Mouse support." lisp/cus-edit.el- :group 'editing) -- lisp/cus-edit.el:(defgroup mouse nil lisp/cus-edit.el- "Input from the mouse." lisp/cus-edit.el- :group 'environment) %