From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug#21072: Brave new mark-defun (and a testing tool) Date: Wed, 15 Feb 2017 14:27:55 -0500 Message-ID: References: <87o9ydrzkr.fsf@mbork.pl> <87mvdriuss.fsf@mbork.pl> <87bmu6icea.fsf@mbork.pl> <87wpctgieu.fsf@mbork.pl> <52e67f43-edcf-09e3-5fd6-6079763fd234@yandex.ru> <87tw7wh9sf.fsf@mbork.pl> <87k28sdka6.fsf@jane> <87efyze00g.fsf@jane> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487186939 28709 195.159.176.226 (15 Feb 2017 19:28:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2017 19:28:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 21072@debbugs.gnu.org, emacs-devel@gnu.org To: Marcin Borkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 15 20:28:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ce5Fy-0006fm-4p for ged-emacs-devel@m.gmane.org; Wed, 15 Feb 2017 20:28:51 +0100 Original-Received: from localhost ([::1]:42665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce5G2-0002pb-8T for ged-emacs-devel@m.gmane.org; Wed, 15 Feb 2017 14:28:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce5FD-0002nR-JL for emacs-devel@gnu.org; Wed, 15 Feb 2017 14:28:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ce5FA-0006cJ-Hz for emacs-devel@gnu.org; Wed, 15 Feb 2017 14:28:03 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce5FA-0006b5-Cx for emacs-devel@gnu.org; Wed, 15 Feb 2017 14:28:00 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v1FJRtYm007044; Wed, 15 Feb 2017 14:27:56 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DCB0960594; Wed, 15 Feb 2017 14:27:55 -0500 (EST) In-Reply-To: <87efyze00g.fsf@jane> (Marcin Borkowski's message of "Wed, 15 Feb 2017 20:18:07 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5949=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5949> : inlines <5699> : streams <1733074> : uri <2377745> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212405 Archived-At: >> Regardless of the answer you give above, I'm wondering in which kind of >> circumstance we'd want to test if we're on "a line containing only >> a comment". > You will be surprised, then, that I actually did use a very similar > function in completely another circumstance: a command that counts > source lines of code in a region, and excludes lines containing only > whitespace, comments and docstrings. (Never mind the discussion about > whether SLOC is meaningful in any sense;-).) My point is that it's not very frequent to need this exact definition of a "comment line" and that there are various other possible definitions one might need in other circumstances. So at the very least, the doc should clarify which definition of "comment line" it uses. Stefan