unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Robert Weiner <rsw@gnu.org>
Cc: rswgnu@gmail.com, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Problem quitting properly from transient keymap with one keystroke
Date: Fri, 20 Oct 2017 13:34:13 -0400	[thread overview]
Message-ID: <jwvbml1n2sb.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <CA+OMD9gyTHjdapgsPAKgfhrvMiDyTLc30_nHTkAjssa_YHyBfQ@mail.gmail.com> (Robert Weiner's message of "Fri, 20 Oct 2017 12:04:51 -0400")

> ​I understand.  Would it be possible to make the exit function run on both
> pre- and post-command hook so that it could use the results of the command​
> when needed and eliminate the need in many cases to call the quit function
> manually?  Or would that cause problems?

I think it would bump into other problems because the keep-pred
predicate expects to be called from pre-command-hook.

IOW, maybe it would have been a valid design, but it would be an
incompatible change.


        Stefan



  reply	other threads:[~2017-10-20 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  3:13 Problem quitting properly from transient keymap with one keystroke Bob Weiner
2017-10-19 15:40 ` Robert Weiner
2017-10-20 12:24 ` Stefan Monnier
2017-10-20 12:27 ` Stefan Monnier
2017-10-20 14:45   ` Robert Weiner
2017-10-20 15:13     ` Stefan Monnier
2017-10-20 16:04       ` Robert Weiner
2017-10-20 17:34         ` Stefan Monnier [this message]
2017-10-20 17:51           ` Robert Weiner
2017-10-20 12:42 ` Oleh Krehel
2017-10-20 14:32   ` Robert Weiner
2017-10-20 14:36   ` Robert Weiner
2017-10-20 14:44   ` Stefan Monnier
2017-10-20 15:26     ` Oleh Krehel
2017-10-20 17:30       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbml1n2sb.fsf-monnier+Inbox@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rsw@gnu.org \
    --cc=rswgnu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).