From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 e1e0a7a 2/2: xref--collect-matches: Speed up on remote Date: Fri, 27 Dec 2019 14:30:02 -0500 Message-ID: References: <20191227141917.13328.16721@vcs0.savannah.gnu.org> <20191227141919.03F1321537@vcs0.savannah.gnu.org> <88d31403-1eb1-e294-4b88-15cacadd52a7@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175848"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 27 20:30:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ikvJy-000jbE-Ah for ged-emacs-devel@m.gmane.org; Fri, 27 Dec 2019 20:30:50 +0100 Original-Received: from localhost ([::1]:38196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikvJw-0005hC-Ph for ged-emacs-devel@m.gmane.org; Fri, 27 Dec 2019 14:30:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40782) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikvJO-0005gq-Uj for emacs-devel@gnu.org; Fri, 27 Dec 2019 14:30:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikvJN-0006MY-DN for emacs-devel@gnu.org; Fri, 27 Dec 2019 14:30:14 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31480) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ikvJN-0006LK-5r for emacs-devel@gnu.org; Fri, 27 Dec 2019 14:30:13 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1E4EC82C1E; Fri, 27 Dec 2019 14:30:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B2E58811E8; Fri, 27 Dec 2019 14:30:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1577475010; bh=6ewT37j9Ob4elPrJUdWmfgkdeldiPLHvsZ7+nDUNAz0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lcPinSRJlNKgd8marNiy4U0KnvOQ4CzHbu3xQ5/bOTQZ1eFI/HlbhvZI34yCutRJS VyPYxwX28L9i4m9KS0KoyeOc2mxohNqsPHa6mLLO08WYn8ng2T5zXUfBgTwwTz3yVo Tqwx5VVyRw1uCiFEdHlAmsTJPPP+skg2L1srtArzjFVvC0NMTdmwTtuOnghs1YMbOb Tq4/Z7I6LC2984Yf471h9bQiOwRYu5VZSKPA7lWv3+uOAd6oAlSj7pl3kF9eufcG+N D8dGQMtj0aSAXeWwwddGyNv9OzKQurweWjg681VnkOxNb0o04n3JcPwySJY+4ZcuXX /f8RrhaCBYFZQ== Original-Received: from alfajor (104-222-126-118.cpe.teksavvy.com [104.222.126.118]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 76E3C1205E1; Fri, 27 Dec 2019 14:30:10 -0500 (EST) In-Reply-To: <88d31403-1eb1-e294-4b88-15cacadd52a7@yandex.ru> (Dmitry Gutov's message of "Fri, 27 Dec 2019 19:18:11 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243713 Archived-At: >>> + (buf (unless remote-id >>> + ;; find-buffer-visiting is slow on remote. >>> + (xref--find-buffer-visiting file))) >> How 'bout using `get-file-buffer` instead, then? > Good idea. Still slower on remote files, but much faster overall. Hmm... why is it slower on remote files? AFAIK it all works locally. It does go through Tramp for the initial `expand-file-name`, but AFAIK this shouldn't need to talk to the remote host (unless it has a ~/ or ~/ in the remote part of the name, I guess?). Stefan