From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding Emms to ELPA (take 2), and a technical question Date: Wed, 27 May 2020 22:36:50 -0400 Message-ID: References: <87pnbwg0up.fsf@rabkins.net> <87mu5trwls.fsf@rabkins.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="75870"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Yoni Rabkin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 28 04:37:27 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1je8QB-000JdD-Lr for ged-emacs-devel@m.gmane-mx.org; Thu, 28 May 2020 04:37:27 +0200 Original-Received: from localhost ([::1]:48092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1je8QA-0002YE-Of for ged-emacs-devel@m.gmane-mx.org; Wed, 27 May 2020 22:37:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1je8Pg-00028S-FS for emacs-devel@gnu.org; Wed, 27 May 2020 22:36:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1je8Pe-00024x-V0 for emacs-devel@gnu.org; Wed, 27 May 2020 22:36:55 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5591080B6D; Wed, 27 May 2020 22:36:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7BC7D808BE; Wed, 27 May 2020 22:36:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1590633411; bh=ZCLZuWkm34U6v9xrpuVCT1RblGruKHcI2ou885nZP/g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WSapbX4MSNXA/bJDiPa/fzQ6LAEWNQ7XDEGoDN44876ev8UcGLmk/B6K8cvs88rUh /hrXu5+cfAVAaO/gKjMpn/RsbK923FGmWmaa0y2EyIBodraQ+Qj26380r3eCbTtIgC b3A4ypfKI7XWn5Jsug0qggr6KgkSJBYoQs8Wq7l/74M5MbPJjKcbdA3yJEL/axEeLL chq2CfPnx8ZiF78EHEOopkl/3WDL4kSoEzs+b/35s7GDDU4lc8JEAuj/EWke0ZYZz6 Bz6fIjvNBhnUvK6c3vfkKA+la36TsXwmkJd8qaBMqBxL9uHZoVwkOt8+OIiXaiS3fI oREAPumkUvSLg== Original-Received: from alfajor (unknown [216.154.27.250]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 484BA1204AE; Wed, 27 May 2020 22:36:51 -0400 (EDT) In-Reply-To: <87mu5trwls.fsf@rabkins.net> (Yoni Rabkin's message of "Wed, 27 May 2020 15:44:47 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/27 22:21:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251529 Archived-At: > outside of using elpa. For instance, I know that there are people who > package Emms for Debian and other OS' using their own package > managers. I don't want to rock their boat if possible. Those people can package ELPA packages their eyes closed (try `apt search elpa-` to see why I think so). They will likely stop using their ad-hoc packaging once it's available via GNU ELPA and will use their generic support for packaging ELPA packages instead. > I made a file in the top-level of the emms distribution named > emms-elpa.el. emms-elpa.el contains the headers (Author, Version, > Package-Requires, etc.), followed by: The file that contains those headers *has* to be called .el, so if you call it `emms-elpa.el` the package will have to be called `emms-elpa`. > ;;;###autoload (load "lisp/emms-auto" nil 'nowarn) LGTM. > You can see it here: > https://git.savannah.gnu.org/cgit/emms.git/tree/emms-elpa.el > > lisp/emms-auto.el is generated by lisp/Makefile to contain autoloads for > the .el files under lisp/ Perfect. > I don't understand how that would be enough to provide a valid load-path > to the files in the lisp/ directory though. That won't be enough. You probably want to add (add-to-list 'load-path (directory-file-name (or (file-name-directory load-file-name) (car load-path)))) to that `lisp/emms-auto.el` file. Stefan