unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: Minor simplification in byte-opt.el
Date: Mon, 27 Jul 2020 10:24:49 -0400	[thread overview]
Message-ID: <jwvblk1ghvc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ECDE2FF5-2FA7-4F2C-BCD6-4178FEFDBA8A@acm.org> ("Mattias Engdegård"'s message of "Mon, 27 Jul 2020 11:38:55 +0200")

>> Could someone look over the patch below to confirm it's safe?
> Thank you, looks decent to me. Good that you spotted the 1+/1-, I forgot about those.

Thanks.

>> Also, as a result of this, there is only one call to
>> `byte-optimize-form-code-walker` left, in `byte-optimize-form`, so maybe
>> the two functions could be merged, tho it's probably not worth the trouble.
> Maybe -- there seems to be little to gain from integrating them other than
> the elimination of the function call.

Exactly :-(

> By the way, what about this little improvement?

Looks good [ tho IMO we shouldn't support `closure` there.  ]


        Stefan




  reply	other threads:[~2020-07-27 14:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26 20:41 Minor simplification in byte-opt.el Stefan Monnier
2020-07-27  9:38 ` Mattias Engdegård
2020-07-27 14:24   ` Stefan Monnier [this message]
2020-07-28 14:43     ` Mattias Engdegård
2020-07-28 14:53       ` Stefan Monnier
2020-07-28 15:18         ` Mattias Engdegård
2020-07-28 16:08           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvblk1ghvc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).