From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 0bd221b: Fix problem of having the wrong window selected after saving foo.gpg Date: Wed, 30 Sep 2020 12:46:22 -0400 Message-ID: References: <20200930153650.16819.40412@vcs0.savannah.gnu.org> <20200930153652.925A9209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 30 18:48:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfH6-00016X-B5 for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 18:48:16 +0200 Original-Received: from localhost ([::1]:57198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNfH5-0004hl-C1 for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 12:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfFP-0003o2-6o for emacs-devel@gnu.org; Wed, 30 Sep 2020 12:46:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfFM-0006nD-Ss for emacs-devel@gnu.org; Wed, 30 Sep 2020 12:46:30 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A5745100275; Wed, 30 Sep 2020 12:46:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 45BCC100216; Wed, 30 Sep 2020 12:46:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1601484384; bh=NoeOhxvsAPd9GfLkNfTBZMOZyzT0C5gz/kLjozZKbIo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AIfXi6meIGRz8vK+/mfoJcbJUb20OcOQFB0WviAIyKkzE676WQ3FFQTk6J7PnjHXT 5coL+uCb4yVIblv8CJLFyCBmp1YqAG0pEbquPEC7scWqTP7RhHhilw7HGW2C94uu66 Ny6yMnwxx139ywspsWLViQaAXbmrXtuL/HOiq3fYHmgledqgU6qc+KoqZ829ZGY62t ZBcY+s4I0paBSL8bBhVa7LxANouffu7gj61L6YWctn7OCcds27Mq+ThtrbmwBuUqFL e3yLbb13fgMYyMgXufYqeeCJja46kusl3jDFgE4J/5S2+Sl+VWUOu6FvqPxK4Y5ksB lvgc8AZuWsE2Q== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 148FA120346; Wed, 30 Sep 2020 12:46:24 -0400 (EDT) In-Reply-To: <20200930153652.925A9209AC@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 11:36:52 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/30 11:51:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256768 Archived-At: > * lisp/epa.el (epa--select-keys): Restore the window configuration > after selecting the key to use (bug#43703). This also ensures > that the buffer we were editing ends up as the current buffer > after saving it, instead of selecting a different window. > + (let ((conf (current-window-configuration))) [...] > + (set-window-configuration conf))))) I think this is called `save-window-excursion`. FWIW, I think `save-window-excursion` is never the right solution because it doesn't take into account the case where `pop-to-buffer` uses another frame. I can never remember which is the function to "undo" a `display-buffer`, but I believe it's something like `quit-window` or `bury-buffer`. We should add a reference to these in the docstring of `display-buffer` and `pop-to-buffer`. Stefan