unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stefan Kangas <stefan@marxist.se>
Cc: Eli Zaretskii <eliz@gnu.org>, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: master 0161c9d 1/2: Load all generic-x.el modes unconditionally
Date: Thu, 11 Feb 2021 10:07:29 -0500	[thread overview]
Message-ID: <jwvblcqir8q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmmqdtdoJkSY+=bOcY0qbbeTq+nWxbkQHLzB4dRbxVvEiA@mail.gmail.com> (Stefan Kangas's message of "Thu, 11 Feb 2021 08:38:31 -0600")

> They may not be very impressive, but surely they are better than
> nothing.  If they are not better than nothing, they should probably
> better be removed.
> What am I missing?

I see two risks, really:

1- some of the regexps used may overlap with some pre-existing entries
   on the default `auto-mode-alist`.  I don't know that it's the case,
   but I think there are enough regexps in `generic-x` and on
   `auto-mode-alist` to make such an overlap possible if not likely.

2- They're only added to `auto-mode-alist` when `generic-x` is loaded,
   which may be too late: they may end up hiding entries added by
   user-installed ELPA packages or by some other part of the user's
   init file.

So, maybe a better solution is to make sure the entries are added to the
*end* of `auto-mode-alist`, which should make them harmless enough.


        Stefan


PS: FWIW, in my case it would make them largely ineffective since I have:

    (setq auto-mode-alist (append auto-mode-alist '(("\\.[^/.]+\\'" ignore t))))




  reply	other threads:[~2021-02-11 15:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210209160550.18823.10795@vcs0.savannah.gnu.org>
     [not found] ` <20210209160551.832FB20AD1@vcs0.savannah.gnu.org>
2021-02-09 17:16   ` master 0161c9d 1/2: Load all generic-x.el modes unconditionally Lars Ingebrigtsen
2021-02-09 17:53     ` Eli Zaretskii
2021-02-09 19:45       ` Stefan Kangas
2021-02-09 20:08         ` Eli Zaretskii
2021-02-09 20:47           ` Stefan Kangas
2021-02-09 21:08             ` Eli Zaretskii
2021-02-09 21:51               ` Stefan Kangas
2021-02-09 22:00           ` Stefan Monnier
2021-02-10  3:26             ` Eli Zaretskii
2021-02-10 14:00               ` Stefan Monnier
2021-02-10 15:39                 ` Eli Zaretskii
2021-02-10 16:44                   ` Stefan Kangas
2021-02-10 17:07                     ` Stefan Monnier
2021-02-10 17:31                       ` Eli Zaretskii
2021-02-10 17:10                     ` Eli Zaretskii
2021-02-10 17:45                       ` Stefan Monnier
2021-02-10 18:29                         ` Matt Armstrong
2021-02-10 19:14                           ` Eli Zaretskii
2021-02-11 14:06                             ` Stefan Kangas
2021-02-11 14:22                           ` Stefan Kangas
2021-02-11 14:47                             ` Eli Zaretskii
2021-02-11 15:10                               ` Stefan Kangas
2021-02-11 14:38                         ` Stefan Kangas
2021-02-11 15:07                           ` Stefan Monnier [this message]
2021-02-11 17:02                             ` Stefan Kangas
2021-02-11 17:12                               ` Eli Zaretskii
2021-02-11 18:00                                 ` Stefan Kangas
2021-02-11 19:29                                   ` Eli Zaretskii
2021-02-11 21:28                                     ` Stefan Kangas
2021-02-12  6:55                                       ` Eli Zaretskii
2021-02-12 13:43                                         ` Stefan Monnier
2021-02-12 14:40                                           ` Eli Zaretskii
2021-02-12 14:46                                             ` Stefan Monnier
2021-02-12 15:07                                               ` Eli Zaretskii
2021-02-12 15:23                                                 ` Stefan Monnier
2021-02-12 15:41                                                   ` Eli Zaretskii
2021-02-12 16:17                                                     ` Stefan Monnier
2021-02-10 16:50                   ` Stefan Monnier
2021-02-10 17:22                     ` Eli Zaretskii
2021-02-10 19:22                       ` Matt Armstrong
2021-02-09 19:00     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvblcqir8q.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).