From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 80e2647: * lisp/filesets.el: Use lexical-binding Date: Fri, 12 Mar 2021 11:59:00 -0500 Message-ID: References: <20210104232347.21177.41247@vcs0.savannah.gnu.org> <20210104232349.75BA220CB7@vcs0.savannah.gnu.org> <87h7lguys8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 12 18:00:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKl8u-0007HT-FR for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Mar 2021 18:00:04 +0100 Original-Received: from localhost ([::1]:33988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKl8t-00056N-1S for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Mar 2021 12:00:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKl7y-0004ER-TK for emacs-devel@gnu.org; Fri, 12 Mar 2021 11:59:06 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKl7v-0004vb-Lm for emacs-devel@gnu.org; Fri, 12 Mar 2021 11:59:05 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 82980100263; Fri, 12 Mar 2021 11:59:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 38B7410020E; Fri, 12 Mar 2021 11:59:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615568341; bh=OXFJZROEli/OClJniu8mysPca9n1wQaD2S4S2Au+DR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bte7sV9O3evIHz0ChKWYc2dDdv3YIN5+pF3A4khnFZtlXQ75QfPCsGLdb9t3ZRzLg VEievpnTMsebqxE85okS0nK0VHWuP8RTLg9mp1DOacPvd+PxhWuI5FkVpky8MmiDrQ Stow3dKDKuLid2WRidLjdTFakg9h5WivpLKflMCOBgg/krNnStafaFY0Vfaqmn+Hcu /TG4Nr6YaiDFLE5S1Z+K18JqmRD2wek5eAbOgTwZ8i7jyZhykqfvUT7ZD6mK0C8QJU T/Sv+c4Ykb8H5jDoAhYIa0aFnED72dVtRgIl07H2TmFIeqpmjCnvVw0sRauzRoxIao DPJdbw+KN4YGA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0F270120208; Fri, 12 Mar 2021 11:59:01 -0500 (EST) In-Reply-To: <87h7lguys8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Mar 2021 17:23:03 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266410 Archived-At: > Now, filesets.el is a twisty maze of functions, but this seems to be > called via the `filesets-commands' alist, and `filesets-cmd-get-def' > which is called from `filesets-cmd-get-fn', which is called from > `filesets-run-cmd'. Which binds `files' lexically, but is probably what > `filesets-cmd-isearch-getargs' is trying to access? > > I'm not really confident about that analysis, though... Ah the wonderful world of dynamic scoping ;-) I agree with your analysis and pushed a patch that presumes you were right. Stefan