From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: How about making `set-minibuffer-window' obsolete? Date: Tue, 16 Mar 2021 19:28:48 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 17 00:30:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMJ95-000ADD-EF for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 00:30:39 +0100 Original-Received: from localhost ([::1]:46368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMJ94-0001eS-FY for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Mar 2021 19:30:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMJ7P-00007x-Nu for emacs-devel@gnu.org; Tue, 16 Mar 2021 19:28:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMJ7M-000698-EE for emacs-devel@gnu.org; Tue, 16 Mar 2021 19:28:54 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C71180EE8; Tue, 16 Mar 2021 19:28:51 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C573980EB2; Tue, 16 Mar 2021 19:28:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615937329; bh=mT0fuHYwf0H0LEwnnK/WAGHHncbGHBy/9WQyiENlrwg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ka1NDwgUWPA2qJxs7QyQSr0lYR9bvSlGKNUhWw9OIf2eivi5R4djqjAn6GnhG0OQp Kd/5teyIz25GhCJAe5YIEH5hz51Y2YOxBquHBti0+Lm04j4mHsuN5NUSCmBIrcG17k MWgvKDC5Mr3ZMiyQP18BXgjqAMdFoqApnyoEn6mwgldKE6Wj+d0CmwXoNEiA5XuTcX em09+tp/xWJy3oG1y5+MpPpJRWjZSvpz+88Gq1GoXVx3K0Pb7y0t9aARj4t1KdWDv1 9p4Sm6CTc7J1r6+xlkisJWGwoS4E9sl0iBCD3kDIr1XeeDoFWUP/0XcRMsEGmSKDez EQ4i8QViEjqWA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 96AE8120312; Tue, 16 Mar 2021 19:28:49 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Tue, 16 Mar 2021 18:16:35 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266512 Archived-At: > This function just sets the C variable minibuf_window. This variable is > defined (by comment) to be the minibuffer window of the selected frame. > So setting it to a random mini-window will cause nasty problems. AFAICT it's not that bad in the sense that it may cause a temporary odd behavior but will be undone next time you select another frame. Still, it can't see what it can be used for. I'd strongly recommend marking it obsolete, indeed. This part of the code is tricky enough without having to deal with such old code whose intended behavior has been lost. Stefan