From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 5183123: Add Tramp recompilation Date: Fri, 23 Apr 2021 16:47:15 -0400 Message-ID: References: <20210419095256.30298.23862@vcs0.savannah.gnu.org> <20210419095259.0651220FD4@vcs0.savannah.gnu.org> <878s59m0lq.fsf@tcd.ie> <87im4cnajz.fsf@gmx.de> <87eef0n4ce.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21726"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 23 22:55:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1la2pf-0005YX-3t for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 22:55:23 +0200 Original-Received: from localhost ([::1]:58182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1la2pe-0000DO-5P for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 16:55:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la2hv-0006Ru-Nk for emacs-devel@gnu.org; Fri, 23 Apr 2021 16:47:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la2hr-0003iO-Fs for emacs-devel@gnu.org; Fri, 23 Apr 2021 16:47:22 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4BD4080931; Fri, 23 Apr 2021 16:47:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C17BE801AB; Fri, 23 Apr 2021 16:47:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619210836; bh=JSfJ/WHSsPb2lgfsk6IInrXMCf8WH2xs+Ozey3zSx7Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ibI08/Qnu2ANGIHYr8xT7nqGa2J300sJ2j7yxKyCFP8TZRBf03qdrkyijOLDuK/Cf ytLSWFQLUFqbEBjlYBWGzRIC+Fc8tqU+lV6znDWMSyIvq3DdEeKw1P9t+kamxBFkI3 XUWSXY0d3KjSV4QqVYoWVbHi+UC2blzG3V53YSdOQ34uwPZmb7QpSM7Jtzt6T97gnL wrLiEOOe+9udgpyPDgs8uVDBbuuCpoorirVaMKFFluWZFb83uzqyRJkYyqpTUGl9jk mFNN7q8yfN9TaatTPwmgXmlnJQz3+gL5qf07Phq9XY+2sd93XsCaRxMGw4vlvrZYHP jjtiaiJpPgMYw== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8AD8E12020E; Fri, 23 Apr 2021 16:47:16 -0400 (EDT) In-Reply-To: <87eef0n4ce.fsf@gmx.de> (Michael Albinus's message of "Fri, 23 Apr 2021 22:17:05 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268329 Archived-At: >> I think we should treat this is a bug in package.el: we already have >> code to try and avoid such problems, so apparently it doesn't do its job >> in this case. > The point is that simply unloading Tramp didn't work. The way package.el tries to deal with it currently is not by unloading the package (which we consider as too risky) but by force-loading the new files over the old ones. E.g. we load ~/.emacs.d/elpa/.../tramp-compat.el before starting the compilation if we see that `tramp-compat` is in the load-history. I recommend you open a bug report for the current problem, and we can try and figure out what's the root cause of the miscompilation. That will help us figure out how to better avoid such problems. > That's why I start a new Emacs instance via "emacs -Q" for > recompilation. Maybe we could use this approach in package.el? The `async` package provides such a solution indeed. It'd be good to integrate it into Emacs proper. > I'll happily remove tramp-recompile-elpa from Tramp once recompilation > is fixed in package.el. But since Tramp is backwards compatible (down to > Emacs 25.1 ATM), this will take years. I'm not bothered by the existence of `tramp-recompile-elpa` (interactive or not). I just saw that "a lot of effort" was expanded trying to make it work smoothly whereas I thought we should spend more time making it unnecessary. >>>> [ Also, I don't see why we need `tramp-recompile-elpa`. >>>> I do see a need for `M-x package-recompile`, OTOH. ] >>> D'accord. >> Patches warmly welcome, > I'll have a look at it. No promise for a working patch, of course. If you take the first step, I can probably help take the second. Stefan