* Re: [elpa] externals/corfu 79a2a61 2/2: Improve orderless support
[not found] ` <20210507111836.5094220DFD@vcs0.savannah.gnu.org>
@ 2021-05-07 13:01 ` Stefan Monnier
2021-05-07 13:19 ` Daniel Mendler
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2021-05-07 13:01 UTC (permalink / raw)
To: emacs-devel; +Cc: Daniel Mendler
> @@ -339,7 +340,8 @@ Set to nil in order to disable confirmation."
> cands))
> ((symbol-function #'orderless-highlight-matches)
> (lambda (pattern cands)
Usually we write `fboundp` when we want to test if a function is bound.
Of course, `symbol-function` does the job as well (the two functions
could be aliases of each other nowadays) but it's not idiomatic.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [elpa] externals/corfu 79a2a61 2/2: Improve orderless support
2021-05-07 13:01 ` [elpa] externals/corfu 79a2a61 2/2: Improve orderless support Stefan Monnier
@ 2021-05-07 13:19 ` Daniel Mendler
2021-05-07 13:28 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mendler @ 2021-05-07 13:19 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
On 5/7/21 3:01 PM, Stefan Monnier wrote:
> Usually we write `fboundp` when we want to test if a function is bound.
> Of course, `symbol-function` does the job as well (the two functions
> could be aliases of each other nowadays) but it's not idiomatic.
Of course. Maybe you missed the context of the code here? This is a
`cl-letf` and I am using `symbol-function` to overwrite the function
using the gv expander. This is pretty ugly code, but I hope we get
support for deferred highlighting in Emacs itself (bug#47711).
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] externals/corfu 79a2a61 2/2: Improve orderless support
2021-05-07 13:19 ` Daniel Mendler
@ 2021-05-07 13:28 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2021-05-07 13:28 UTC (permalink / raw)
To: Daniel Mendler; +Cc: emacs-devel
>> Usually we write `fboundp` when we want to test if a function is bound.
>> Of course, `symbol-function` does the job as well (the two functions
>> could be aliases of each other nowadays) but it's not idiomatic.
>
> Of course. Maybe you missed the context of the code here? This is a
> `cl-letf` and I am using `symbol-function` to overwrite the function
> using the gv expander. This is pretty ugly code, but I hope we get
> support for deferred highlighting in Emacs itself (bug#47711).
Duh! Sorry 'bout the noise,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-07 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210507111834.24945.47387@vcs0.savannah.gnu.org>
[not found] ` <20210507111836.5094220DFD@vcs0.savannah.gnu.org>
2021-05-07 13:01 ` [elpa] externals/corfu 79a2a61 2/2: Improve orderless support Stefan Monnier
2021-05-07 13:19 ` Daniel Mendler
2021-05-07 13:28 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).