From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Sat, 08 May 2021 09:15:18 -0400 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler , Gregory Heytings , Dmitry Gutov , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 15:16:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfMoX-0009fo-U0 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 15:16:14 +0200 Original-Received: from localhost ([::1]:55434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfMoW-0007Rb-7W for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 09:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfMnl-0006ba-AM for emacs-devel@gnu.org; Sat, 08 May 2021 09:15:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfMni-00056O-HG for emacs-devel@gnu.org; Sat, 08 May 2021 09:15:24 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8541F441497; Sat, 8 May 2021 09:15:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2C3E5441492; Sat, 8 May 2021 09:15:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620479719; bh=HdkDLd92nOkyX9p4AHAP2BZua/gHWwrJSLhjD26ldD8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Rs6XpN9r+NTjt/bz++adCF0E7mDOQSILqdpUNmZAx7CH6jgGOAa/zyg87BwID4HbW dnGDpny+5GUg+OuKxCMyK2GiuIptMrCdGEeIYLiNyVwC9UMnKub8OC0DWGZ1gYQX6X 2KkHYNiCpBotfbTrS44nFso1VYJaRaL4xq0MrgW70ZCiSTcQHNZBhFPrlVzlHihyVx 7yLBdRHRGcap2qIq4BXC05ZUcwFT4ZiMsBF5gTIPPfDFOb1/EYHdHxkntCPFHh2ej5 L390t+lZVT+8z6FgleickGkI/wGzdwRegCt55qUJdibMVr5vi50ij6HziInk3Rx2MX 5gK/1agiaqfHQ== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF2061202BC; Sat, 8 May 2021 09:15:18 -0400 (EDT) In-Reply-To: <87sg2ymq6j.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 07 May 2021 20:03:48 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269046 Archived-At: > I tried to remove `read-char-by-name-group`, but it has a feature > currently not supported by `group-function`: > > (defcustom read-char-by-name-group nil > "How to group characters for `read-char-by-name' completion. > When t, split characters to sections of Unicode blocks > sorted alphabetically." > ===================== > > It seems a new function is needed to sort groups, e.g. `group-sort-function`. I think whether the groups should be sorted alphabetically or "by order of appearance" can be a choice made by the UI rather than by the completion-table. Stefan