From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 91418d27e9: Add new functions for computing character metrics for windows Date: Sat, 30 Apr 2022 10:34:58 -0400 Message-ID: References: <165123811050.20687.5215165731843845332@vcs2.savannah.gnu.org> <20220429131511.9BD62C01683@vcs2.savannah.gnu.org> <87v8usc7wz.fsf@gnus.org> <83czgzacfk.fsf@gnu.org> <87ilqq4yfc.fsf@gnus.org> <837d768ywx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: larsi@gnus.org, malsburg@posteo.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 30 16:35:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkoCQ-0008sS-Jb for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 16:35:54 +0200 Original-Received: from localhost ([::1]:54830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkoCP-0000B4-41 for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 10:35:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkoBf-0007tp-VP for emacs-devel@gnu.org; Sat, 30 Apr 2022 10:35:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkoBd-0006xM-Fb; Sat, 30 Apr 2022 10:35:06 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8FC3440F4F; Sat, 30 Apr 2022 10:35:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8E963440A3E; Sat, 30 Apr 2022 10:34:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651329299; bh=tU+qOryQTENqFV4JBhHRt1rJKE5WYE/vlOgvUM1IoPM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aTDLGDuDn42QjE/GGgr3VhYjpDByfmQxPaJRNyLnB9FI1Ct0m152QgqK8fhtx0n1c 8s/bv+amGIYa2MnFQ7q9p7NO5z4Qt8lafdWcZbfjEqYTNLsNNMDmFKCx9lWDUWXrve C/TL9ikmQ5iebn3YjrjDRcMPXju382aSaPMWhNDKrzYPWRlR4Ep70lVSgRXdjvq1cB +MxuSyJhJHDBGkUZ5FJlCO2QcKP+7Qswfkz3rVE0QGStXJWERjfYlz116LHd649oz/ YP99yW75TriP7dlhL5pdE2JUM26EKHRTdKFga9861px6ZTw4Hf7Y0JvgRnEWCUpe1F tlI4a72ZCSTtQ== Original-Received: from alfajor (modemcable034.207-20-96.mc.videotron.ca [96.20.207.34]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 54289120263; Sat, 30 Apr 2022 10:34:59 -0400 (EDT) In-Reply-To: <837d768ywx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2022 16:48:46 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289058 Archived-At: >> But admittedly, in most cases you can use >> `window-max-characters-per-line only` as a heuristic because of the >> effect of proportional fonts > What else can you do when proportional fonts are used, except account > fro the average width? Indeed. But it just means that (unless you do the kind of job that Lars did in vtable and SHR) the code will always be somewhat broken, and the difference between using `window-max-characters-per-line` or `window-body-width` is in which cases it's broken. >> and faces > The function accepts FACE as the argument. So this is accounted for. I think you missed to "applied to specific parts of the text": the FACE argument only handles the case where the whole line uses that same face. > (And I wonder why this sudden crusade against this function.) For one, because it's name makes it impossible to find when you're looking for "one of those functions that returns some notion of text width". For two, because this was already a nasty mess and this function just adds insult to injury, IMO. Stefan