From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function Date: Tue, 14 Jun 2022 08:44:58 -0400 Message-ID: References: <165484935985.12525.14065631018362412932@vcs2.savannah.gnu.org> <20220610082240.A7222C01683@vcs2.savannah.gnu.org> <87pmjfsc1v.fsf@gnus.org> <874k0rqiwh.fsf@gnus.org> <87tu8qp5hy.fsf@gnus.org> <8735g8oj7z.fsf@gnus.org> <87r13ro3lf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22131"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Daniel Mendler To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 14 14:56:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o165j-0005Yh-Mh for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Jun 2022 14:56:19 +0200 Original-Received: from localhost ([::1]:41896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o165i-00078M-I5 for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Jun 2022 08:56:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15v5-0007OP-Au for emacs-devel@gnu.org; Tue, 14 Jun 2022 08:45:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15uu-0004WQ-0f for emacs-devel@gnu.org; Tue, 14 Jun 2022 08:45:10 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A9F4B100346; Tue, 14 Jun 2022 08:45:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 39ABD10012C; Tue, 14 Jun 2022 08:44:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655210699; bh=boeP+EqnuGxAs77kbKtrIm4RN4B0afS12xkhj24YCs8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GXLekgr+6bADRIx9yim42gnyMFz1NRg0RvANG+2jzUdeVh5Ahb7YN5I46hvvU9Jtx rH6+3ICrn/c2rba3ryhxPlc760JtSFCOoStQ05pxqLNNr7FkzDQi1By0i9Z7eMV9/J hZON66JAWm9H7cWaYS91IKL2u8gR2iOzGECKkVF0iibSuSWoFj0WEfn3y9Uw9X6LvS HxKRspneYtu3jM3ZnZq6+qbDKL4NDNAeeuugBrgI8kxq4De28N5RPBx/AqYOp+h93Z 7PiYXdYYXfSPxXvvA/x7AjCHOV7v/y11v75b29yQL/sAQ4UJzmMt6ag2jrcK/Xidci AdrohfdgSqwAQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09A3D12040A; Tue, 14 Jun 2022 08:44:58 -0400 (EDT) In-Reply-To: <87r13ro3lf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 14 Jun 2022 14:02:20 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291175 Archived-At: Lars Ingebrigtsen [2022-06-14 14:02:20] wrote: > Stefan Monnier writes: >> And in order not to have to understand them, you should move this code >> out into its own function and call it in the same way that >> `minibuffer-completion-confirm` is called (such that >> `minibuffer-completion-confirm` can simply call this function to >> reproduce that default behavior). > > Sorry; I don't follow. The current code does more or less: (cond ((functionp minibuffer-completion-confirm) (funcall minibuffer-completion-confirm ...)) ) and we should change it to: (defun minibuffer-default-handle-completion-options (...) (cond )) [...] (funcall (if (functionp minibuffer-completion-confirm) minibuffer-completion-confirm #'minibuffer-default-handle-completion-options) ...) so that we know for sure that `minibuffer-completion-confirm` can reproduce the default behavior (i.e. that the API is not obviously incomplete), simply by calling `minibuffer-default-handle-completion-options`. You don't need to understand the subtleties of , because you just move the code as-is and then the compiler will tell you if there's a problem (typically because uses vars from the context, which you then need to pass as additional arguments). [ For the same reason, most/all `-function` variables should ideally have a non-nil default value. ] Stefan