From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Docstring hack Date: Sun, 31 Jul 2022 03:52:24 -0400 Message-ID: References: <83bkt6687a.fsf@gnu.org> <871qu2lo29.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10110"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , Lynn Winebarger , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 31 09:53:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oI3lJ-0002Su-FJ for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 09:53:21 +0200 Original-Received: from localhost ([::1]:33338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oI3lI-0002ek-2z for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 03:53:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI3kb-0001yT-4M for emacs-devel@gnu.org; Sun, 31 Jul 2022 03:52:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI3kY-0002bn-9x; Sun, 31 Jul 2022 03:52:35 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C5DC280722; Sun, 31 Jul 2022 03:52:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1884A80065; Sun, 31 Jul 2022 03:52:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659253947; bh=XqNQ5CPAktQEIeBnBXqsWy496YbAi0RaYu+3vFtD8fY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dtAwf9ousAWh7VsvCi9/wYqeEED/RHd4J6iZTntqCDAtyH8jvDgI2/TxDnRr3rLk/ 3a3V7cVRvQpnogba7Akomy831SLxKibUWixxRGELDffJ5PEMz3Tpe2+UV6TGf3kjpC HSB9xtgZCbMyfcMpbCzOQipL8MLcNbYKTE2AiPZKV9NgFZV0sssQQH5bL9xOG329Lm UBt5uMRv3oPAi3yC4GFdq+NZNt/Sg/ook2m2D+q2paW+pq/HJVUyonZYm3pJ7oqTNT YNcVsRlfXwdH+x6T5b92GVBUqKC3vSRjInMNsBXHaL1CuibimDVDdkVQ8FUrPyNjur EBp0hVDwonsNQ== Original-Received: from milanesa (dyn.144-85-173-218.dsl.vtx.ch [144.85.173.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3538B120387; Sun, 31 Jul 2022 03:52:26 -0400 (EDT) In-Reply-To: <871qu2lo29.fsf@yahoo.com> (Po Lu's message of "Sat, 30 Jul 2022 21:36:46 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292900 Archived-At: > I think the problem is this: > > (format args...) > > will result in (format 0 args...) during dumping. Ah, I see. This is a hack I'd like to get rid of, indeed. AFAIK nowadays it's only useful for those docstrings found in lisp/loaddefs.el since it's the only Lisp file we still scrape for docstrings (to put them in etc/DOC). [ E.g. If we were to byte-compile `lisp/loaddefs.el`, then it wouldn't be used at all any more, I believe. We have loose plans o do that, but someone needs to dig into it to see what that breaks and how to fix it. ] IOW we can tighten the test in `read_string_literal` to replace strings with 0 only in this one specific case. Stefan