From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments Date: Thu, 22 Sep 2022 12:55:10 -0400 Message-ID: References: <166378878197.3568.7077863090259744101@vcs2.savannah.gnu.org> <20220921193303.1B687C11D81@vcs2.savannah.gnu.org> <87v8pfbw1g.fsf@gmail.com> <87edw3o0hs.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Robert Pluim , emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 22 20:32:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obQzs-00005i-47 for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 20:32:28 +0200 Original-Received: from localhost ([::1]:35994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obQzr-0000Y7-1Z for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 14:32:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obPTq-0004CZ-8H for emacs-devel@gnu.org; Thu, 22 Sep 2022 12:55:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obPTm-0000Cw-UB for emacs-devel@gnu.org; Thu, 22 Sep 2022 12:55:17 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E9D0C80365; Thu, 22 Sep 2022 12:55:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 23FAF8079C; Thu, 22 Sep 2022 12:55:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663865711; bh=Ls4eYR9zAxhkK3CoVLISP3zixYAFewWO6z1QXOLduGU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Yh9pj7dGsjR4KtJRdqydSttI9tTcKENC56fyPmTds/IXB73hJlzbNpCv8lpb+hkGh 6Ili+MLk8WuXsMl3RCkIBjpI8bIu8b7z1p/LPniUAkpS0LdlFjNX2j92XmaYDB3f0e aNwykMB4yTxtS8ljDdEM5PciDkIgJEwwX186v6iiFrF8cOWWjbl8B0Yw36WQVhA9qw EuM650V3oCdYCAodSk/irxTqhAIzIc3SM2gMO0HdCMAGf05Yi0x7niEnt5S7Wbc8cM TWJXN1BmRaxQGhtvfk1Qe39NjXlLvQtXfc3fF/SVl8JcE4T9ednCVa8f2CfxXWmfMh kcUCyj6S0qANA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 137081208FE; Thu, 22 Sep 2022 12:55:11 -0400 (EDT) In-Reply-To: <87edw3o0hs.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 22 Sep 2022 09:08:31 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295997 Archived-At: >> Robert Pluim [2022-09-22 11:25:31] wrote: >>> Sean> +(defvar vc-want-edit-command-p nil >>> Sean> + "If non-nil, let user edit the VC shell command before running it.") >> >> BTW, `-p` stands for "predicate", IOW *functions* that return booleans. > > I thought that in Lisp we often call boolean values predicates too, even > though that violates the usage of 'predicate' in mathematics. > > Is there some other convention for booleans like this one? Usually we don't need it because the name says it, like `vc-let-user-edit-commands`. There is a convention to use `-flag` for boolean variables. I have a strong dislike of that convention, tho, because all too often what starts as a boolean var is later extended to allow for more variety of values. There is another convention the use `-mode` for boolean variables, when they are (very) exposed to the user and defined via `define-minor-mode`. I like this convention but I don't think it should apply here. Stefan