From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 09b5f00613: ; Fix calls to treesit functions Date: Sun, 18 Dec 2022 15:19:53 -0500 Message-ID: References: <167138365421.15060.2886694741391315956@vcs2.savannah.gnu.org> <20221218171414.77B8EC0060F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 18 21:20:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p709M-00079C-2U for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Dec 2022 21:20:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p708i-0006bZ-Vb; Sun, 18 Dec 2022 15:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p708g-0006bH-8x for emacs-devel@gnu.org; Sun, 18 Dec 2022 15:20:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p708e-000117-EZ; Sun, 18 Dec 2022 15:20:01 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A293E80712; Sun, 18 Dec 2022 15:19:57 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1A3A880536; Sun, 18 Dec 2022 15:19:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671394796; bh=A2afHGyTHm8eLrSeX+jTdZPFBc+zDzCuYo5NnEZba9M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YogaNBbKBU0wvh6Ul8OkzljBm6QOsEH+m78ZN0IL/kMyRXccxjvuCJgdfycne5qi2 9+x0OYr+kEq32d6ez++Uae1BkfgsvqrQb+5Uu4cu4cffOIDsrZ9pGX4hupmFwGI+5C piF6OhQeyUDN0GCGYoKPwcXx0sdJNptZEbzSo4k50ddbwMj0sBOXQM90f+cyvfMeiu a90HWliHu5m5DcSRGp9HqwFCVivlvnI9Oa/VlbduQGkXyV5HbWRh9w4HLEH73JY82F D+R0KckABaZcQxM0JfHJtI1Y95oUn1IfrcM0fk6XDeoA8fS8xwc+w2gjU3p8MrAlEK +VcPAKpaVkm0A== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E82C512083D; Sun, 18 Dec 2022 15:19:55 -0500 (EST) In-Reply-To: <20221218171414.77B8EC0060F@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 18 Dec 2022 12:14:14 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301618 Archived-At: > +(declare-function treesit-available-p "treesit.c") > (declare-function treesit-parser-list "treesit.c") > (declare-function treesit-node-type "treesit.c") > > @@ -156,7 +157,8 @@ or follows point." > (interactive "P") > (save-excursion > (let ((treesit-text-node > - (and (treesit-parser-list) > + (and (treesit-available-p) > + (treesit-parser-list) How 'bout always defining `treesit-parser-list` (and making it return `nil` if Emacs was compiled without Tree-sitter support)? Most places that can make use of Tree-sitter probably would probably prefer not to have to worry about the subtle distinction between "Tree-sitter support is available but not for this major mode" and "Tree-sitter support is not available at all". Stefan