From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master updated (cd8d3f3379e -> 1b0348d9593)
Date: Sun, 18 Jun 2023 14:28:00 -0400 [thread overview]
Message-ID: <jwvbkhczl1d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <875y7k3gif.fsf@gmx.de> (Michael Albinus's message of "Sun, 18 Jun 2023 18:02:48 +0200")
> It looks like this patch series has broken esh-util-tests.el. Try
>
> --8<---------------cut here---------------start------------->8---
> # make -C test esh-util-tests
> ...
> Test esh-util-test/eshell-stringify/list condition:
> (ert-test-failed
> ((should (equal (eshell-stringify ...) "((1 2)\n (3 . 4))")) :form
> (equal "((1 2) (3 . 4))" "((1 2)\n (3 . 4))") :value nil
> :explanation
> (arrays-of-different-length 15 16 "((1 2) (3 . 4))"
> "((1 2)\n (3 . 4))" first-mismatch-at 6)))
> FAILED 9/13 esh-util-test/eshell-stringify/list (0.000212 sec) at lisp/eshell/esh-util-tests.el:47
> --8<---------------cut here---------------end--------------->8---
I don't think it's a bug if the output of the pretty printer is
((1 2) (3 . 4))
rather than
((1 2)
(3 . 4))
so I think the esh-util-tests is just too strict: both output are valid,
as are various others such as
((1
2)
(3
. 4))
Not knowing what the test is indeed the check I'm not sure how it should
be fixed. Maybe replace all `[ \n]+` with SPC ?
Stefan
next prev parent reply other threads:[~2023-06-18 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168703958196.28351.5331986860123726819@vcs2.savannah.gnu.org>
2023-06-18 16:02 ` master updated (cd8d3f3379e -> 1b0348d9593) Michael Albinus
2023-06-18 18:28 ` Stefan Monnier [this message]
2023-06-18 18:30 ` Eli Zaretskii
2023-06-18 18:39 ` Eli Zaretskii
2023-06-18 21:39 ` Jim Porter
[not found] ` <20230617220622.EC118C1925A@vcs2.savannah.gnu.org>
2023-07-14 3:31 ` master 2f181d60323 3/6: pp.el (pp-fill): New default pp function Michael Heerdegen
2023-07-14 4:57 ` Stefan Monnier
2023-07-15 2:48 ` Michael Heerdegen
2023-07-15 15:19 ` Stefan Monnier
2023-07-17 9:58 ` Eric S Fraga
2023-07-17 12:24 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbkhczl1d.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).