From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/android a5b74e2ff62: Initialize text conversion hooks for each C Mode buffer Date: Fri, 27 Oct 2023 16:05:18 -0400 Message-ID: References: <168629733551.31969.16984560043233541806@vcs2.savannah.gnu.org> <20230609075536.0E919C1924D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22314"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, bug-cc-mode@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 27 22:06:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwT5v-0005bO-U8 for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Oct 2023 22:06:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwT5C-0001gz-SO; Fri, 27 Oct 2023 16:05:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwT5A-0001gV-AQ for emacs-devel@gnu.org; Fri, 27 Oct 2023 16:05:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwT58-0003Rg-9d; Fri, 27 Oct 2023 16:05:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 05F8410013E; Fri, 27 Oct 2023 16:05:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698437119; bh=J86CaUz+K4eqcWoVNIQaO4FQeKgCRRuP5Ym4Bp7lnk8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bv4xMt6Vj2vb77DP5FT2gAlj1JaIXid65PNqrqD8EaiNtBEuYatK06+ffKPAnLinp 05RXZx5zEYbBgc37dE1F6y0QjAY8NW/CdSX7vMqztzdnzCmoNQ+bh83p8b/hY01kAF kpSbdJvPasY0O0d0uqAXEb7qTUSvUgm+FWE0Aon11jyJWpBGsNxgTUfqJzebIsaYpI gxxDzSOTBN3elCP5SG1mWPvnz1xn1XcdRBh4UNvJo3uSn3qP+m7u0szFFSEqnl/4iM d3qYJym5Jqth1rszSwwStIV2H4r4VfJ7zkRqBQOG8Z6W6c8vCScMCWud2ZONJMHgZd R3FcF2WUtZLMg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 53E8D10006B; Fri, 27 Oct 2023 16:05:19 -0400 (EDT) Original-Received: from pastel (unknown [45.72.195.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 292C2120460; Fri, 27 Oct 2023 16:05:19 -0400 (EDT) In-Reply-To: <20230609075536.0E919C1924D@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Fri, 9 Jun 2023 03:55:35 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311941 Archived-At: Hi Po Lu (and Alan), Regarding this patch of yours from a few months back: > diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el > index 1364117bdc8..88e0aebb9a2 100644 > --- a/lisp/progmodes/cc-mode.el > +++ b/lisp/progmodes/cc-mode.el > @@ -251,13 +251,14 @@ control). See \"cc-mode.el\" for more info." > (when (fboundp 'electric-indent-local-mode) > (add-hook 'electric-indent-mode-hook 'c-electric-indent-mode-hook) > (add-hook 'electric-indent-local-mode-hook > - 'c-electric-indent-local-mode-hook)) > - ;; Set up text conversion, for Emacs >= 30.0 > - (when (boundp 'post-text-conversion-hook) > - (add-hook 'post-text-conversion-hook #'c-post-text-conversion))) > + 'c-electric-indent-local-mode-hook))) > ;; Will try initialization hooks again if they failed. > (put 'c-initialize-cc-mode initprop c-initialization-ok)))) > > + ;; Set up text conversion, for Emacs >= 30.0 > + (when (boundp 'post-text-conversion-hook) > + (add-hook 'post-text-conversion-hook #'c-post-text-conversion)) > + > (unless new-style-init > (c-init-language-vars-for 'c-mode))) Why is this specific to CC-mode? Is it because other modes handle electricity via the `post-self-insert-hook` instead? And why is the hook function added globally? Wouldn't it be better to add it buffer-locally instead? Stefan