Re: master e8f5df51751: Declare nested backquotes unsupported in Pcase patterns (bug#72328)

Re: master e8f5df51751: Declare nested backquotes unsupported in Pcase patterns (bug#72328)

[Andrea Corallo]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

> branch: master
> commit e8f5df5175170d36f526e46b63b3d428bb9a8950
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     Declare nested backquotes unsupported in Pcase patterns (bug#72328)
>
>     The current behavior is inconsistent with that of the normal backquote
>     macro, so to avoid surprises, warn about the use of nested backquotes.
>
>     * lisp/emacs-lisp/pcase.el (pcase--expand-\`): Warn about nested backquotes.
>
>     * lisp/emacs-lisp/testcover.el (testcover-analyze-coverage)
>     (testcover-analyze-coverage-wrapped-form): Avoid nested backquotes

Hello,

this is introducing the following on my build on master:

========
Warning: pcase pattern '(a b) shadowed by previous pcase pattern
Warning: Nested ` are not supported
Test pcase-tests-quote-optimization backtrace:
  signal(ert-test-failed (((should (= 1 (with-temp-buffer (prin1 exp1
  ert-fail(((should (= 1 (with-temp-buffer (prin1 exp1 (current-buffer
  #f(compiled-function () #<bytecode -0x1976b0af9035f65f>)()
  #f(compiled-function () #<bytecode 0x179d5d17f865dad7>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x179d5d17f865dad7
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name pcase-tests-quote-optimization :docum
  ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test pcase-tests-quote-optimization condition:
    (ert-test-failed
     ((should (= 1 (with-temp-buffer ... ... ...))) :form (= 1 2) :value
      nil))
   FAILED  10/13  pcase-tests-quote-optimization (0.000206 sec) at lisp/emacs-lisp/pcase-tests.el:80

========

Thanks

  Andrea

Re: master e8f5df51751: Declare nested backquotes unsupported in Pcase patterns (bug#72328)

[Stefan Monnier]

> Test pcase-tests-quote-optimization condition:
>     (ert-test-failed
>      ((should (= 1 (with-temp-buffer ... ... ...))) :form (= 1 2) :value
>       nil))
>    FAILED  10/13  pcase-tests-quote-optimization (0.000206 sec) at lisp/emacs-lisp/pcase-tests.el:80

Should work again now,


        Stefan

Re: master e8f5df51751: Declare nested backquotes unsupported in Pcase patterns (bug#72328)

[Andrea Corallo]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Test pcase-tests-quote-optimization condition:
>>     (ert-test-failed
>>      ((should (= 1 (with-temp-buffer ... ... ...))) :form (= 1 2) :value
>>       nil))
>>    FAILED  10/13  pcase-tests-quote-optimization (0.000206 sec) at lisp/emacs-lisp/pcase-tests.el:80
>
> Should work again now,

Thanks Stefan

  Andrea