From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: wdired Date: Mon, 27 Feb 2006 14:01:30 -0500 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141191633 23764 80.91.229.2 (1 Mar 2006 05:40:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Mar 2006 05:40:33 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 01 06:40:30 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FEK4O-00080b-31 for ged-emacs-devel@m.gmane.org; Wed, 01 Mar 2006 06:40:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FEK4N-0002F8-E6 for ged-emacs-devel@m.gmane.org; Wed, 01 Mar 2006 00:40:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FEArg-0008BP-J8 for emacs-devel@gnu.org; Tue, 28 Feb 2006 14:50:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FEArZ-0008AH-C8 for emacs-devel@gnu.org; Tue, 28 Feb 2006 14:50:27 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FEArW-00087G-6x for emacs-devel@gnu.org; Tue, 28 Feb 2006 14:50:22 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FDndh-000301-3Z for emacs-devel@gnu.org; Mon, 27 Feb 2006 14:02:33 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 147D433E607; Mon, 27 Feb 2006 14:01:38 -0500 (EST) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 94F5947C2; Mon, 27 Feb 2006 14:01:30 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 6D19F71524; Mon, 27 Feb 2006 14:01:30 -0500 (EST) Original-To: martin rudalics In-Reply-To: (martin rudalics's message of "Fri, 24 Feb 2006 17:43:50 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51032 Archived-At: > The patch below attempts to correct this behavior and simplify the code. > * wdired.el (wdired-change-to-wdired-mode, wdired-finish-edit, > wdired-search-and-rename, wdired-do-symlink-changes, > wdired-do-perm-changes): Simplify code. > (wdired-preprocess-files, wdired-preprocess-symlinks, > wdired-preprocess-perms): Make read-only property of preceding > character rear-nonsticky to avoid that it can be modified. Put > old-name and old-link properties on character preceding name and > replace put-text-property by add-text-properties. > (wdired-get-filename, wdired-get-previous-link): Get old-name > and old-link properties from character preceding name and > simplify code. > (wdired-preprocess-perms, wdired-set-bit, wdired-toggle-bit): > Make local-map property rear-nonsticky to avoid that text > following permissions may be modified. Use add-text-properties > instead of put-text-property when changing a permission bit. > (wdired-change-to-dired-mode): Remove stickiness properties. For what it's worth, the patch looks OK to me. Stefan