unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: wdired
Date: Mon, 27 Feb 2006 14:01:30 -0500	[thread overview]
Message-ID: <jwvaccc1va1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <wkzmkgaerd.fsf@gmx.at> (martin rudalics's message of "Fri, 24 Feb 2006 17:43:50 +0100")

> The patch below attempts to correct this behavior and simplify the code.

> 	* wdired.el (wdired-change-to-wdired-mode, wdired-finish-edit,
>         wdired-search-and-rename, wdired-do-symlink-changes,
>         wdired-do-perm-changes): Simplify code.
> 	(wdired-preprocess-files, wdired-preprocess-symlinks,
>         wdired-preprocess-perms): Make read-only property of preceding
>         character rear-nonsticky to avoid that it can be modified.  Put
>         old-name and old-link properties on character preceding name and
>         replace put-text-property by add-text-properties.
> 	(wdired-get-filename, wdired-get-previous-link): Get old-name
> 	and old-link properties from character preceding name and
> 	simplify code.
> 	(wdired-preprocess-perms, wdired-set-bit, wdired-toggle-bit):
> 	Make local-map property rear-nonsticky to avoid that text
> 	following permissions may be modified.  Use add-text-properties
> 	instead of put-text-property when changing a permission bit.
> 	(wdired-change-to-dired-mode): Remove stickiness properties.

For what it's worth, the patch looks OK to me.


        Stefan

  reply	other threads:[~2006-02-27 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24 16:43 wdired martin rudalics
2006-02-27 19:01 ` Stefan Monnier [this message]
2006-02-27 19:43   ` wdired martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvaccc1va1.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).