unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: storm@cua.dk (Kim F. Storm)
Cc: Andreas Schwab <schwab@suse.de>,
	Chong Yidong <cyd@stupidchicken.com>,
	emacs-devel <emacs-devel@gnu.org>,
	martin rudalics <rudalics@gmx.at>
Subject: Re: transpose-regions
Date: Fri, 23 Mar 2007 12:42:00 -0400	[thread overview]
Message-ID: <jwvaby4q6cy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3vegsgefz.fsf@kfs-l.imdomain.dk> (Kim F. Storm's message of "Fri\, 23 Mar 2007 16\:36\:00 +0100")

>> I'm running on GNU/Linux with the latest CVS.
> Which uses conservative stack marking too.
> So it's definitely not "just" a missing GC pro somewhere.

I think I see the problem: intervals are not Lisp objects and thus they are
not detected by the conservative stack scanning (and they can't be GCPRO'd
either).

I.e. make_interval does:

     ...
     newi = (struct interval_block *) lisp_malloc (sizeof *newi,
                                                   MEM_TYPE_NON_LISP);
     ...

while mark_maybe_pointer does:

      ...
      switch (m->type)
	{
	case MEM_TYPE_NON_LISP:
	  /* Nothing to do; not a pointer to Lisp memory.  */
	  break;
      ...

and m->type can probably never be MEM_TYPE_NON_LISP anyway, because
lisp_malloc does:

    ...
    if (val && type != MEM_TYPE_NON_LISP)
      mem_insert (val, (char *) val + nbytes, type);
    ...


so after the copy_intervals, if Fset_text_properties ends up calling the
garbage collector (probably via some after-change-function) you're hosed.

Personally, I think the best solution is to rewrite transpose-regions in
Lisp.  After all, it's only called from gnus/deuglify.el and from
games/hanoi.el (and interactively as well, of course).


        Stefan

  reply	other threads:[~2007-03-23 16:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 11:03 transpose-regions martin rudalics
2007-03-22 14:49 ` transpose-regions Kim F. Storm
2007-03-22 20:13   ` transpose-regions Nick Roberts
2007-03-22 21:30     ` transpose-regions martin rudalics
2007-03-22 21:36       ` transpose-regions David Kastrup
2007-03-22 21:59         ` transpose-regions martin rudalics
2007-03-23 13:52         ` transpose-regions Eli Zaretskii
2007-03-22 15:04 ` transpose-regions Chong Yidong
2007-03-22 15:26   ` transpose-regions martin rudalics
2007-03-22 15:59     ` transpose-regions Chong Yidong
2007-03-22 17:07       ` transpose-regions martin rudalics
2007-03-22 18:06         ` transpose-regions Chong Yidong
2007-03-22 19:19           ` transpose-regions martin rudalics
2007-03-22 20:24             ` transpose-regions Chong Yidong
2007-03-22 21:32               ` transpose-regions martin rudalics
2007-03-22 22:13               ` transpose-regions martin rudalics
2007-03-22 21:51           ` transpose-regions Andreas Schwab
2007-03-23 13:46           ` transpose-regions Eli Zaretskii
2007-03-23  1:28 ` transpose-regions Chong Yidong
2007-03-23  9:05   ` transpose-regions martin rudalics
2007-03-23 10:55   ` transpose-regions Andreas Schwab
2007-03-23 11:50     ` transpose-regions Kim F. Storm
2007-03-23 12:08       ` transpose-regions martin rudalics
2007-03-23 14:09       ` transpose-regions Chong Yidong
2007-03-23 15:36         ` transpose-regions Kim F. Storm
2007-03-23 16:42           ` Stefan Monnier [this message]
2007-03-23 17:34             ` transpose-regions Chong Yidong
2007-03-23 18:17               ` transpose-regions martin rudalics
2007-03-23 22:32             ` transpose-regions Richard Stallman
2007-03-23 22:50               ` transpose-regions Stefan Monnier
2007-03-28  4:56                 ` transpose-regions Richard Stallman
2007-03-24 20:24             ` transpose-regions Karl Fogel
2007-03-23 18:00     ` transpose-regions Richard Stallman
2007-03-23 22:39       ` transpose-regions Stefan Monnier
2007-03-24 15:51       ` transpose-regions Chong Yidong
2007-03-25 17:28         ` transpose-regions Richard Stallman
2007-03-23 15:39   ` transpose-regions Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvaby4q6cy.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    --cc=schwab@suse.de \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).