unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
Cc: esr@snark.thyrsus.com, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: C-x v l does not move to current log entry
Date: Fri, 10 Aug 2007 04:09:26 -0400	[thread overview]
Message-ID: <jwvabsz6cmm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <18099.60849.120058.919034@rgrjr.dyndns.org> (Bob Rogers's message of "Fri\, 3 Aug 2007 23\:08\:33 -0400")

> This turns out to be coming from log-view-font-lock-keywords, which has
> a value that looks something like this:

> 	((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append)))
>          (eval \` (\,log-view-message-re . log-view-message-face)))

> The source (log-view.el:170) specifies backquoted forms inside a quoted
> form; it appears that the reader is not handling this correctly.  The
> attached patch replaces the backquotes with explicit "cons" calls; this
> is not a real fix, and I include it only to show that it does make the
> error messages go away.  Fixing the reader is undoubtedly hairier.

It turns out that the handling of nested backquotes was simply not working.
The reader's treatment worked (although IIRC it only works since Emacs-21),
but the backquote expansion was flawed.  As for the above bug it comes from
an incorrect treatment of the new backquote style (and its nesting) in the
printer (used by the byte-compiler, hence the above problem only appeared
when using log-view.elc rather than log-view.el which is why it worked fine
when I wrote the code).

I believe I've now fixed both problems in the 22 branch (should be merged into
the trunk in a couple days).


        Stefan "Duh!"

  parent reply	other threads:[~2007-08-10  8:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  7:51 C-x v l does not move to current log entry Jan Djärv
2007-08-02 15:45 ` Richard Stallman
2007-08-04  3:08   ` Bob Rogers
2007-08-05  3:06     ` Richard Stallman
2007-08-10  8:09     ` Stefan Monnier [this message]
2007-08-12  4:15     ` Richard Stallman
2007-08-12  8:30       ` Jan Djärv
2007-08-12 22:01         ` Stefan Monnier
2007-08-13  6:03           ` Jan Djärv
2007-09-10  6:53 ` Jan Djärv
2007-09-12  8:30   ` Glenn Morris
2007-09-14  6:41     ` Jan Djärv
2007-09-15 22:25       ` Stefan Monnier
2007-09-16  8:55         ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvabsz6cmm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=esr@snark.thyrsus.com \
    --cc=rms@gnu.org \
    --cc=rogers-emacs@rgrjr.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).