From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: C-r and C-s in minibuffer should search completion Date: Sat, 19 Apr 2008 17:10:16 -0400 Message-ID: References: <87lk440z31.fsf@jurta.org> <87od8xccz6.fsf@jurta.org> <87hceouksk.fsf@jurta.org> <87y77zlqji.fsf@jurta.org> <873aq2czp4.fsf@jurta.org> <871w5j2ca1.fsf@jurta.org> <87r6d6vjg2.fsf@jurta.org> <87od89sb4y.fsf@jurta.org> <87mynsrg9m.fsf@jurta.org> <87zlrp8zn1.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208639435 28012 80.91.229.12 (19 Apr 2008 21:10:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Apr 2008 21:10:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 19 23:11:09 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JnKKu-0000dD-Q4 for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 23:11:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnKKF-0007Vo-HN for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 17:10:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnKKB-0007Vh-If for emacs-devel@gnu.org; Sat, 19 Apr 2008 17:10:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnKKA-0007VS-1q for emacs-devel@gnu.org; Sat, 19 Apr 2008 17:10:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnKK9-0007VP-Rh for emacs-devel@gnu.org; Sat, 19 Apr 2008 17:10:17 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JnKK9-0006qj-QO for emacs-devel@gnu.org; Sat, 19 Apr 2008 17:10:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At0FAP78CUhMCqsI/2dsb2JhbACBYKht X-IronPort-AV: E=Sophos;i="4.25,684,1199682000"; d="scan'208";a="18777922" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 19 Apr 2008 17:10:16 -0400 Original-Received: from pastel.home ([76.10.171.8]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id ZZD73816; Sat, 19 Apr 2008 17:10:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6FBBC8DDE; Sat, 19 Apr 2008 17:10:16 -0400 (EDT) In-Reply-To: <87zlrp8zn1.fsf@jurta.org> (Juri Linkov's message of "Sat, 19 Apr 2008 23:11:46 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95478 Archived-At: >>> If there is no equivalent of Vbuffer_alist in Lisp, then >>> internal-complete-buffer-sans-current will produce wrong results. >> >> I don't understand what's the problem. Your previously posted code >> should work just fine, for example. > I understood that the reason not to move `internal-complete-buffer' > to Lisp is because it uses the internal variable Vbuffer_alist. > Since these two functions are equivalent in behavior with the exception > that one of them omits the current buffer, I thought that it would be > better to have equivalent implementations Actually it's better in that case to have one of the two implemented as a "diff" over the other. > by having both in Lisp with removing possible problems of using > Vbuffer_alist that you mentioned. Yes, except that your proposal doesn't remove possible problems with using Vbuffer_alist (that problem is if someone gets hold of this list and does things like "rplcd" (i.e. setcdr) on it). >> Or you could define it on top of the internal-complete-buffer code, >> using the `predicate' argument. > Do you mean something like > (defun internal-complete-buffer-sans-current (string predicate flag) > "Perform completion on buffer names excluding the current buffer. > Like `internal-complete-buffer', but removes the current buffer from > the completion list." > (let ((current-buffer (buffer-name (other-buffer (current-buffer) t)))) > (internal-complete-buffer > string (lambda (buffer) (not (equal current-buffer buffer))) flag))) Yes, except it should not ignore `predicate'. You could define it in terms of completion-table-with-predicate (100% untested code, of course): (defun internal-complete-buffer-except (&optional buf) (lexical-let ((except (if (stringp buf) buf (buffer-name buf)))) (apply-partially 'completion-table-with-predicate 'internal-complete-buffer (lambda (name) (not (equal name except))) nil))) Stefan