From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: C-r and C-s in minibuffer should search completion
Date: Sat, 19 Apr 2008 17:10:16 -0400 [thread overview]
Message-ID: <jwvabjp5znu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zlrp8zn1.fsf@jurta.org> (Juri Linkov's message of "Sat, 19 Apr 2008 23:11:46 +0300")
>>> If there is no equivalent of Vbuffer_alist in Lisp, then
>>> internal-complete-buffer-sans-current will produce wrong results.
>>
>> I don't understand what's the problem. Your previously posted code
>> should work just fine, for example.
> I understood that the reason not to move `internal-complete-buffer'
> to Lisp is because it uses the internal variable Vbuffer_alist.
> Since these two functions are equivalent in behavior with the exception
> that one of them omits the current buffer, I thought that it would be
> better to have equivalent implementations
Actually it's better in that case to have one of the two implemented as
a "diff" over the other.
> by having both in Lisp with removing possible problems of using
> Vbuffer_alist that you mentioned.
Yes, except that your proposal doesn't remove possible problems with using
Vbuffer_alist (that problem is if someone gets hold of this list
and does things like "rplcd" (i.e. setcdr) on it).
>> Or you could define it on top of the internal-complete-buffer code,
>> using the `predicate' argument.
> Do you mean something like
> (defun internal-complete-buffer-sans-current (string predicate flag)
> "Perform completion on buffer names excluding the current buffer.
> Like `internal-complete-buffer', but removes the current buffer from
> the completion list."
> (let ((current-buffer (buffer-name (other-buffer (current-buffer) t))))
> (internal-complete-buffer
> string (lambda (buffer) (not (equal current-buffer buffer))) flag)))
Yes, except it should not ignore `predicate'.
You could define it in terms of completion-table-with-predicate (100%
untested code, of course):
(defun internal-complete-buffer-except (&optional buf)
(lexical-let ((except (if (stringp buf) buf (buffer-name buf))))
(apply-partially 'completion-table-with-predicate
'internal-complete-buffer
(lambda (name) (not (equal name except)))
nil)))
Stefan
next prev parent reply other threads:[~2008-04-19 21:10 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 19:13 C-r and C-s in minibuffer should search completion Stefan Monnier
2008-03-20 19:35 ` Juri Linkov
2008-03-20 20:07 ` Lennart Borgman (gmail)
2008-03-20 20:38 ` Juri Linkov
2008-03-20 20:54 ` Drew Adams
2008-03-20 23:07 ` Juri Linkov
2008-03-20 22:13 ` Stefan Monnier
2008-03-20 22:27 ` Drew Adams
2008-03-20 23:03 ` Juri Linkov
2008-03-21 1:26 ` Stefan Monnier
2008-03-22 1:17 ` Juri Linkov
2008-03-22 17:04 ` Stefan Monnier
2008-03-23 2:17 ` Juri Linkov
2008-03-23 3:24 ` Stefan Monnier
2008-03-29 1:00 ` Xavier Maillard
2008-03-29 12:30 ` Juri Linkov
2008-03-29 16:23 ` Drew Adams
2008-03-30 0:38 ` Juri Linkov
2008-03-30 2:38 ` Drew Adams
2008-03-20 20:44 ` Drew Adams
2008-03-25 21:44 ` Juri Linkov
2008-03-26 2:31 ` Stefan Monnier
2008-03-26 7:01 ` Drew Adams
2008-03-26 14:41 ` Stefan Monnier
2008-03-26 17:07 ` Drew Adams
2008-03-26 10:56 ` Juri Linkov
2008-03-26 14:47 ` Stefan Monnier
2008-03-27 0:44 ` Juri Linkov
2008-03-27 2:43 ` Stefan Monnier
2008-03-27 23:43 ` Juri Linkov
2008-03-29 4:03 ` Stefan Monnier
2008-03-30 0:44 ` Juri Linkov
2008-03-30 4:01 ` Stefan Monnier
2008-03-30 18:32 ` Juri Linkov
2008-03-30 22:41 ` Stefan Monnier
2008-03-30 23:50 ` Juri Linkov
2008-03-31 2:11 ` Stefan Monnier
2008-04-03 22:59 ` Juri Linkov
2008-04-04 1:18 ` Stefan Monnier
2008-04-06 20:45 ` Juri Linkov
2008-04-07 15:32 ` Stefan Monnier
2008-04-15 22:28 ` Juri Linkov
2008-04-16 2:08 ` Stefan Monnier
2008-04-16 23:16 ` Juri Linkov
2008-04-17 1:41 ` Stefan Monnier
2008-04-17 9:18 ` Juri Linkov
2008-04-18 1:07 ` Stefan Monnier
2008-04-19 20:11 ` Juri Linkov
2008-04-19 21:10 ` Stefan Monnier [this message]
2008-04-19 22:46 ` Juri Linkov
2008-04-20 2:44 ` Stefan Monnier
2008-04-21 21:51 ` Juri Linkov
2008-04-22 3:11 ` Stefan Monnier
2008-04-22 20:59 ` Juri Linkov
2008-04-23 2:28 ` Stefan Monnier
2008-04-21 3:07 ` Richard Stallman
2008-04-21 22:54 ` Juri Linkov
2008-04-22 3:10 ` Stefan Monnier
2008-03-30 0:44 ` minibuffer-default-add-shell-commands (was: C-r and C-s in minibuffer should search completion) Juri Linkov
2008-03-30 4:08 ` minibuffer-default-add-shell-commands Stefan Monnier
2008-03-30 18:28 ` minibuffer-default-add-shell-commands Juri Linkov
2008-03-30 11:30 ` minibuffer-default-add-shell-commands Reiner Steib
2008-03-30 18:31 ` minibuffer-default-add-shell-commands Juri Linkov
2008-03-30 20:25 ` minibuffer-default-add-shell-commands Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvabjp5znu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).