* tar-mode shouldn't use write-contents-functions
@ 2009-01-01 17:29 Stefan Monnier
2009-01-01 17:40 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2009-01-01 17:29 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
Could you explain your latest change to tar-mode:
;;; tar-mode.el --- simple editing of tar files from GNU emacs
----------------------------
revision 1.133
date: 2008-12-31 04:58:53 -0500; author: schwab; state: Exp; lines: +13 -10; commitid: bktiZYl153iysBwt;
(tar-mode): Set write-contents-functions instead of
write-region-annotate-functions.
(tar-mode-write-contents): New function.
(tar-write-region-annotate): Remove.
----------------------------
This seems to basically undo my earlier change:
revision 1.128
date: 2008-05-28 13:43:58 -0400; author: monnier; state: Exp; lines: +15 -22; commitid: vJEploj5uzkA0L4t;
(tar-summarize-buffer): Fix reporter initialization.
(tar-mode): Use write-region-annotate-functions rather than
write-contents-functions.
(tar-extract): Remove unused var `pos'.
(tar-subfile-save-buffer): Remove unused var `following-descs'.
(tar-mode-write-file): Remove.
(tar-write-region-annotate): New function.
----------------------------
Could you explain the reason for it? IIUC your change causes (among
other things) auto-save to fail (it saves the summary rather than the
raw tar data).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tar-mode shouldn't use write-contents-functions
2009-01-01 17:29 tar-mode shouldn't use write-contents-functions Stefan Monnier
@ 2009-01-01 17:40 ` Andreas Schwab
2009-01-01 20:46 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2009-01-01 17:40 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Could you explain your latest change to tar-mode:
tar-write-region-annotate does not work.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tar-mode shouldn't use write-contents-functions
2009-01-01 17:40 ` Andreas Schwab
@ 2009-01-01 20:46 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2009-01-01 20:46 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
>> Could you explain your latest change to tar-mode:
> tar-write-region-annotate does not work.
I'm a bit overwhelmed by the amount of information here.
Could you summarize?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-01 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-01 17:29 tar-mode shouldn't use write-contents-functions Stefan Monnier
2009-01-01 17:40 ` Andreas Schwab
2009-01-01 20:46 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).