From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Mon, 06 Jun 2011 12:21:35 -0300 Message-ID: References: <201106040034.15598.ruediger@c-plusplus.de> <831uz9esv1.fsf@gnu.org> <201106041913.09203.ruediger@c-plusplus.de> <8762olmk6y.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1307380407 30863 80.91.229.12 (6 Jun 2011 17:13:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2011 17:13:27 +0000 (UTC) Cc: =?iso-8859-1?Q?R=FCdiger?= Sonderfeld , emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 06 19:13:23 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QTdMg-0002VH-4n for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2011 19:13:22 +0200 Original-Received: from localhost ([::1]:56937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTdMe-0007hp-Mn for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2011 13:13:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTbcd-0002EY-9g for emacs-devel@gnu.org; Mon, 06 Jun 2011 11:21:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTbca-0000Y7-Rd for emacs-devel@gnu.org; Mon, 06 Jun 2011 11:21:42 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:43534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTbca-0000Y3-Hq for emacs-devel@gnu.org; Mon, 06 Jun 2011 11:21:40 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:35868 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QTbcZ-0007gO-8U; Mon, 06 Jun 2011 11:21:39 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3C74966189; Mon, 6 Jun 2011 12:21:35 -0300 (ART) In-Reply-To: <8762olmk6y.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Sat, 04 Jun 2011 22:10:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140232 Archived-At: Thanks for your review, I generally agree with your comments. > Moreover, you need to decide what to do given, for example: > (progn (file-watch "foo" 'modify 'notify-modify) > (file-watch "foo" 'move 'notify-move)) > Is this OK, is this an error, is this "close to" an error? I think dired shouldn't need to know if some other package decided to watch the same directory, so having several watchers for the same file should be accepted and work correctly, i.e. both callbacks should be run when needed. > I think a simple "file is already in" check is insufficient. > + watch_list =3D Fcons(Fcons(make_number(watchdesc), Flist(2, args)),= watch_list); > You can use =E2=80=98acons=E2=80=99: (acons K V ALIST) =E2=89=A1 (cons (c= ons K V) ALIST). No, Fcons is the right thing to use there. We could #define ACONS(a,b,c) Fcons(Fcons(a,b),c) but that's orthogonal to this patch. Stefan