From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Inefficiency in Bgotoifnil byte-code instruction Date: Tue, 03 Jul 2012 19:02:38 -0400 Message-ID: References: <87k3yq2htz.fsf@fleche.redhat.com> <87y5n2vupa.fsf@fleche.redhat.com> <87wr2kvr6g.fsf@fleche.redhat.com> <87ipe4vjy1.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341356595 29502 80.91.229.3 (3 Jul 2012 23:03:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 Jul 2012 23:03:15 +0000 (UTC) Cc: Mohamed Ben-Ahssene , emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 04 01:02:47 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SmC7K-0008Vi-2R for ged-emacs-devel@m.gmane.org; Wed, 04 Jul 2012 01:02:46 +0200 Original-Received: from localhost ([::1]:44560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmC7J-0001sc-0Z for ged-emacs-devel@m.gmane.org; Tue, 03 Jul 2012 19:02:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmC7F-0001ru-M7 for emacs-devel@gnu.org; Tue, 03 Jul 2012 19:02:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmC7E-000381-1q for emacs-devel@gnu.org; Tue, 03 Jul 2012 19:02:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:38463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmC7D-00037Y-Td for emacs-devel@gnu.org; Tue, 03 Jul 2012 19:02:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09MCquH/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="192585910" Original-Received: from 76-10-171-135.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.171.135]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jul 2012 19:02:38 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 39A45AE322; Tue, 3 Jul 2012 19:02:38 -0400 (EDT) In-Reply-To: <87ipe4vjy1.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 03 Jul 2012 11:22:14 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151402 Archived-At: > I took the "value" approach because the bytecode values are fixed, and I > thought it was safer to be explicit about them. > The backslashes are just needed because I made one big #define. Yes, as I said, I think it's OK. Maybe better would be if the threaded version actually checked that the `value' is correct (i.e. is one more than the previous one) rather than just ignore that argument. > Another approach (used in gcc, gdb, etc) is to put the opcode defines > into a ".def" file and then include it in multiple places. I'm not sure it's better, since, as you say, the values are fixed by external factors. Feel free to install, Stefan