From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] 01/03: [gnugo frolic int] Regularize keymap decl + init. Date: Wed, 09 Apr 2014 09:45:48 -0400 Message-ID: References: <20140409121712.31423.53123@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1397051177 11298 80.91.229.3 (9 Apr 2014 13:46:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Apr 2014 13:46:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 09 15:46:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXspN-0006uB-OE for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2014 15:46:09 +0200 Original-Received: from localhost ([::1]:46213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXspN-0000DA-Bx for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2014 09:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXspD-0000Bs-6y for emacs-devel@gnu.org; Wed, 09 Apr 2014 09:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXsp5-0003Hr-IQ for emacs-devel@gnu.org; Wed, 09 Apr 2014 09:45:59 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:44487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXsp5-0003Hd-Ca for emacs-devel@gnu.org; Wed, 09 Apr 2014 09:45:51 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s39Djnrl013295; Wed, 9 Apr 2014 09:45:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0F01860534; Wed, 9 Apr 2014 09:45:49 -0400 (EDT) In-Reply-To: (Thien-Thi Nguyen's message of "Wed, 09 Apr 2014 12:17:14 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4907=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4907> : inlines <707> : streams <1155155> : uri <1724719> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171365 Archived-At: > +(unless gnugo-frolic-mode-map > + (setq gnugo-frolic-mode-map (make-sparse-keymap)) > + (suppress-keymap gnugo-frolic-mode-map) > + (mapc (lambda (pair) > + (define-key gnugo-frolic-mode-map (car pair) (cdr pair))) > + '(("q" . gnugo-frolic-quit) > + ("C" . gnugo-frolic-quit) ; like =E2=80=98View-kill-a= nd-leave=E2=80=99 > + ("\C-b" . gnugo-frolic-backward-branch) > + ("\C-f" . gnugo-frolic-forward-branch) > + ("j" . gnugo-frolic-exchange-left) > + ("J" . gnugo-frolic-rotate-left) > + ("k" . gnugo-frolic-exchange-right) > + ("K" . gnugo-frolic-rotate-right) > + ("\C-m" . gnugo-frolic-set-as-main-line) > + ("\C-\M-p" . gnugo-frolic-prune-branch) > + ("o" . gnugo-frolic-return-to-origin)))) =20 Any reason not to use the standard (defvar gnugo-frolic-mode-map (let ((map (make-sparse-keymap))) (suppress-keymap map) (mapc (lambda (pair) (define-key map (car pair) (cdr pair))) '(("q" . gnugo-frolic-quit) ("C" . gnugo-frolic-quit) ; like =E2=80=98View-kill= -and-leave=E2=80=99 ("\C-b" . gnugo-frolic-backward-branch) ("\C-f" . gnugo-frolic-forward-branch) ("j" . gnugo-frolic-exchange-left) ("J" . gnugo-frolic-rotate-left) ("k" . gnugo-frolic-exchange-right) ("K" . gnugo-frolic-rotate-right) ("\C-m" . gnugo-frolic-set-as-main-line) ("\C-\M-p" . gnugo-frolic-prune-branch) ("o" . gnugo-frolic-return-to-origin))) map)) Or even using pcase-dolist: (defvar gnugo-frolic-mode-map (let ((map (make-sparse-keymap))) (suppress-keymap map) (pcase-dolist (`(,key . ,cmd) '(("q" . gnugo-frolic-quit) ("C" . gnugo-frolic-quit) ; like =E2=80=98= View-kill-and-leave=E2=80=99 ("\C-b" . gnugo-frolic-backward-branch) ("\C-f" . gnugo-frolic-forward-branch) ("j" . gnugo-frolic-exchange-left) ("J" . gnugo-frolic-rotate-left) ("k" . gnugo-frolic-exchange-right) ("K" . gnugo-frolic-rotate-right) ("\C-m" . gnugo-frolic-set-as-main-line) ("\C-\M-p" . gnugo-frolic-prune-branch) ("o" . gnugo-frolic-return-to-origin)) (define-key map key cmd))) map)) -- Stefan