From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117002: Correctly treat progn contents as toplevel forms when byte compiling
Date: Mon, 21 Apr 2014 11:09:46 -0400 [thread overview]
Message-ID: <jwva9berarv.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1WcAcP-0006zy-MJ@vcs.savannah.gnu.org> (Daniel Colascione's message of "Mon, 21 Apr 2014 09:34:29 +0000")
> Correctly treat progn contents as toplevel forms when byte compiling
Your commit messages should be copies of the ChangeLog entry.
Could you describe the case(s) that this fixes?
> + ;; Macroexpand (not macroexpand-all!)
That could be a problem.
> form at toplevel in case it
> + ;; expands into a toplevel-equivalent `progn'. See CLHS section
> + ;; 3.2.3.1, "Processing of Top Level Forms".
Note that Elisp is not Common-Lisp, so we don't always follow
Common-Lisp's design decisions (although, we often do, as well).
> The semantics are very
> + ;; subtle: see test/automated/bytecomp-tests.el for interesting
> + ;; cases.
> + (setf form (macroexpand form byte-compile-macro-environment))
> + (if (eq (car-safe form) 'progn)
> + (cons 'progn
> + (mapcar (lambda (subform)
> + (byte-compile-recurse-toplevel
> + subform non-toplevel-case))
> + (cdr form)))
> + (funcall non-toplevel-case form)))
`non-toplevel-case' is declared as optional, but here you call it
without ensuring it's non-nil. IOW it shouldn't be optional.
> (defconst byte-compile-initial-macro-environment
> '(
> ;; (byte-compiler-options . (lambda (&rest forms)
> ;; (apply 'byte-compiler-options-handler forms)))
> (declare-function . byte-compile-macroexpand-declare-function)
> (eval-when-compile . (lambda (&rest body)
Oops, we have a bug here. We should be using `(... ,(lambda ...
Stefan
next parent reply other threads:[~2014-04-21 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WcAcP-0006zy-MJ@vcs.savannah.gnu.org>
2014-04-21 15:09 ` Stefan Monnier [this message]
2014-04-21 17:44 ` [Emacs-diffs] trunk r117002: Correctly treat progn contents as toplevel forms when byte compiling Daniel Colascione
2014-04-21 22:09 ` Stefan Monnier
2014-04-21 22:29 ` Daniel Colascione
2014-04-22 2:09 ` Stefan Monnier
2014-04-22 2:21 ` Daniel Colascione
2014-04-22 4:25 ` Stefan Monnier
2014-04-22 4:46 ` Daniel Colascione
2014-04-22 15:06 ` Stefan Monnier
2014-04-22 17:22 ` Daniel Colascione
2014-04-22 18:13 ` Daniel Colascione
2014-04-22 18:37 ` Stefan Monnier
2014-04-22 19:08 ` Daniel Colascione
2014-04-22 18:44 ` Drew Adams
2014-04-22 19:23 ` Daniel Colascione
2014-04-22 19:59 ` Drew Adams
2014-04-22 20:10 ` Daniel Colascione
2014-04-22 20:41 ` Drew Adams
2014-04-22 21:05 ` Daniel Colascione
2014-04-23 0:50 ` Stephen J. Turnbull
2014-04-22 18:29 ` Stefan Monnier
2014-04-22 15:20 ` Stefan Monnier
2014-04-22 17:04 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva9berarv.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).